Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2686663002: Reland of [parsing] Fix maybe-assigned for loop variables. (Closed)

Created:
3 years, 10 months ago by Michael Hablich
Modified:
3 years, 10 months ago
Reviewers:
neis, adamk, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [parsing] Fix maybe-assigned for loop variables. (patchset #1 id:1 of https://codereview.chromium.org/2679263002/ ) Reason for revert: False alarm, bot hiccup Original issue's description: > Revert of [parsing] Fix maybe-assigned for loop variables. (patchset #3 id:40001 of https://codereview.chromium.org/2673403003/ ) > > Reason for revert: > Speculative revert because of https://codereview.chromium.org/2679163002/. > > Original issue's description: > > [parsing] Fix maybe-assigned for loop variables. > > > > Due to hoisting, the value of a 'var'-declared variable may actually change even > > if the code contains only the "initial" assignment, namely when that assignment > > occurs inside a loop. For example: > > > > let i = 10; > > do { var x = i } while (i--): > > > > As a simple and very conservative approximation of this, we explicitly mark > > as maybe-assigned any non-lexical variable whose "declaration" does not > > syntactically occur in the function scope. (In the example above, it > > occurs in a block scope.) > > > > BUG=v8:5636 > > > > Review-Url: https://codereview.chromium.org/2673403003 > > Cr-Commit-Position: refs/heads/master@{#42989} > > Committed: https://chromium.googlesource.com/v8/v8/+/a33fcd663b28b8846e12b97c30d6e7d837767f86 > > TBR=marja@chromium.org,adamk@chromium.org,neis@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5636 > > Review-Url: https://codereview.chromium.org/2679263002 > Cr-Commit-Position: refs/heads/master@{#43010} > Committed: https://chromium.googlesource.com/v8/v8/+/f3ae5ccf57690d8c2d87c4fe1d10b103ad6a4ab3 TBR=marja@chromium.org,adamk@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5636 Review-Url: https://codereview.chromium.org/2686663002 Cr-Commit-Position: refs/heads/master@{#43013} Committed: https://chromium.googlesource.com/v8/v8/+/5f9c89af7019761f56a87f4e56a319c34b35ebff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+658 lines, -209 lines) Patch
M src/ast/scopes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +26 lines, -2 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M test/cctest/parsing/test-preparser.cc View 2 chunks +209 lines, -202 lines 0 comments Download
M test/cctest/scope-test-helper.h View 2 chunks +8 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +359 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-5636-1.js View 1 chunk +22 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-5636-2.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Hablich
Created Reland of [parsing] Fix maybe-assigned for loop variables.
3 years, 10 months ago (2017-02-07 20:42:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686663002/1
3 years, 10 months ago (2017-02-07 20:42:33 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 20:43:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5f9c89af7019761f56a87f4e56a319c34b3...

Powered by Google App Engine
This is Rietveld 408576698