Revert of [parsing] Fix maybe-assigned for loop variables.

Revert of [parsing] Fix maybe-assigned for loop variables. (patchset #3 id:40001 of https://codereview.chromium.org/2673403003/ )

Reason for revert:
Speculative revert because of https://codereview.chromium.org/2679163002/.

Original issue's description:
> [parsing] Fix maybe-assigned for loop variables.
> 
> Due to hoisting, the value of a 'var'-declared variable may actually change even
> if the code contains only the "initial" assignment, namely when that assignment
> occurs inside a loop.  For example:
> 
>   let i = 10;
>   do { var x = i } while (i--):
> 
> As a simple and very conservative approximation of this, we explicitly mark
> as maybe-assigned any non-lexical variable whose "declaration" does not
> syntactically occur in the function scope.  (In the example above, it
> occurs in a block scope.)
> 
> BUG=v8:5636
> 
> Review-Url: https://codereview.chromium.org/2673403003
> Cr-Commit-Position: refs/heads/master@{#42989}
> Committed: https://chromium.googlesource.com/v8/v8/+/a33fcd663b28b8846e12b97c30d6e7d837767f86

TBR=marja@chromium.org,adamk@chromium.org,neis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5636
Review-Url: https://codereview.chromium.org/2679263002
Cr-Commit-Position: refs/heads/master@{#43010}
Committed: https://chromium.googlesource.com/v8/v8/+/f3ae5ccf57690d8c2d87c4fe1d10b103ad6a4ab3

[Michael Hablich, 2017-02-07 19:32:57]

The CQ bit was checked by hablich@chromium.org

[Michael Hablich, 2017-02-07 19:32:57]

Created Revert of [parsing] Fix maybe-assigned for loop variables.

[commit-bot: I haz the power, 2017-02-07 19:33:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:33:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 19:33:14]

Failed to apply patch for test/cctest/parsing/test-preparser.cc:
While running git apply --index -p1;
  error: patch failed: test/cctest/parsing/test-preparser.cc:30
  error: test/cctest/parsing/test-preparser.cc: patch does not apply

Patch:       test/cctest/parsing/test-preparser.cc
Index: test/cctest/parsing/test-preparser.cc
diff --git a/test/cctest/parsing/test-preparser.cc
b/test/cctest/parsing/test-preparser.cc
index
be9bd8512d5c6f7b7a3b029def05cd55fb09c01b..07c270de27e2cfda040c2982228c0b7b8a22618a
100644
--- a/test/cctest/parsing/test-preparser.cc
+++ b/test/cctest/parsing/test-preparser.cc
@@ -30,274 +30,268 @@
   const char* eager_inner = "(function inner(%s) { %s })()";
 
   struct {
-    bool precise_maybe_assigned;
     const char* params;
     const char* source;
   } inners[] = {
       // Simple cases
-      {1, "", "var1;"},
-      {1, "", "var1 = 5;"},
-      {1, "", "if (true) {}"},
-      {1, "", "function f1() {}"},
+      {"", "var1;"},
+      {"", "var1 = 5;"},
+      {"", "if (true) {}"},
+      {"", "function f1() {}"},
 
       // Var declarations and assignments.
-      {1, "", "var var1;"},
-      {1, "", "var var1; var1 = 5;"},
-      {0, "", "if (true) { var var1; }"},
-      {1, "", "if (true) { var var1; var1 = 5; }"},
-      {1, "", "var var1; function f() { var1; }"},
-      {1, "", "var var1; var1 = 5; function f() { var1; }"},
-      {1, "", "var var1; function f() { var1 = 5; }"},
+      {"", "var var1;"},
+      {"", "var var1; var1 = 5;"},
+      {"", "if (true) { var var1; }"},
+      {"", "if (true) { var var1; var1 = 5; }"},
+      {"", "var var1; function f() { var1; }"},
+      {"", "var var1; var1 = 5; function f() { var1; }"},
+      {"", "var var1; function f() { var1 = 5; }"},
 
       // Let declarations and assignments.
-      {1, "", "let var1;"},
-      {1, "", "let var1; var1 = 5;"},
-      {1, "", "if (true) { let var1; }"},
-      {1, "", "if (true) { let var1; var1 = 5; }"},
-      {1, "", "let var1; function f() { var1; }"},
-      {1, "", "let var1; var1 = 5; function f() { var1; }"},
-      {1, "", "let var1; function f() { var1 = 5; }"},
+      {"", "let var1;"},
+      {"", "let var1; var1 = 5;"},
+      {"", "if (true) { let var1; }"},
+      {"", "if (true) { let var1; var1 = 5; }"},
+      {"", "let var1; function f() { var1; }"},
+      {"", "let var1; var1 = 5; function f() { var1; }"},
+      {"", "let var1; function f() { var1 = 5; }"},
 
       // Const declarations.
-      {1, "", "const var1 = 5;"},
-      {1, "", "if (true) { const var1 = 5; }"},
-      {1, "", "const var1 = 5; function f() { var1; }"},
+      {"", "const var1 = 5;"},
+      {"", "if (true) { const var1 = 5; }"},
+      {"", "const var1 = 5; function f() { var1; }"},
 
       // Redeclarations.
-      {1, "", "var var1; var var1;"},
-      {1, "", "var var1; var var1; var1 = 5;"},
-      {1, "", "var var1; if (true) { var var1; }"},
-      {1, "", "if (true) { var var1; var var1; }"},
-      {1, "", "var var1; if (true) { var var1; var1 = 5; }"},
-      {1, "", "if (true) { var var1; var var1; var1 = 5; }"},
-      {1, "", "var var1; var var1; function f() { var1; }"},
-      {1, "", "var var1; var var1; function f() { var1 = 5; }"},
+      {"", "var var1; var var1;"},
+      {"", "var var1; var var1; var1 = 5;"},
+      {"", "var var1; if (true) { var var1; }"},
+      {"", "if (true) { var var1; var var1; }"},
+      {"", "var var1; if (true) { var var1; var1 = 5; }"},
+      {"", "if (true) { var var1; var var1; var1 = 5; }"},
+      {"", "var var1; var var1; function f() { var1; }"},
+      {"", "var var1; var var1; function f() { var1 = 5; }"},
 
       // Shadowing declarations.
-      {1, "", "var var1; if (true) { var var1; }"},
-      {1, "", "var var1; if (true) { let var1; }"},
-      {1, "", "let var1; if (true) { let var1; }"},
-
-      {1, "", "var var1; if (true) { const var1 = 0; }"},
-      {1, "", "const var1 = 0; if (true) { const var1 = 0; }"},
+      {"", "var var1; if (true) { var var1; }"},
+      {"", "var var1; if (true) { let var1; }"},
+      {"", "let var1; if (true) { let var1; }"},
+
+      {"", "var var1; if (true) { const var1 = 0; }"},
+      {"", "const var1 = 0; if (true) { const var1 = 0; }"},
 
       // Arguments and this.
-      {1, "", "arguments;"},
-      {1, "", "arguments = 5;"},
-      {1, "", "if (true) { arguments; }"},
-      {1, "", "if (true) { arguments = 5; }"},
-      {1, "", "function f() { arguments; }"},
-      {1, "", "function f() { arguments = 5; }"},
-
-      {1, "", "this;"},
-      {1, "", "if (true) { this; }"},
-      {1, "", "function f() { this; }"},
+      {"", "arguments;"},
+      {"", "arguments = 5;"},
+      {"", "if (true) { arguments; }"},
+      {"", "if (true) { arguments = 5; }"},
+      {"", "function f() { arguments; }"},
+      {"", "function f() { arguments = 5; }"},
+
+      {"", "this;"},
+      {"", "if (true) { this; }"},
+      {"", "function f() { this; }"},
 
       // Variable called "arguments"
-      {1, "", "var arguments;"},
-      {1, "", "var arguments; arguments = 5;"},
-      {0, "", "if (true) { var arguments; }"},
-      {1, "", "if (true) { var arguments; arguments = 5; }"},
-      {1, "", "var arguments; function f() { arguments; }"},
-      {1, "", "var arguments; arguments = 5; function f() { arguments; }"},
-      {1, "", "var arguments; function f() { arguments = 5; }"},
-
-      {1, "", "let arguments;"},
-      {1, "", "let arguments; arguments = 5;"},
-      {1, "", "if (true) { let arguments; }"},
-      {1, "", "if (true) { let arguments; arguments = 5; }"},
-      {1, "", "let arguments; function f() { arguments; }"},
-      {1, "", "let arguments; arguments = 5; function f() { arguments; }"},
-      {1, "", "let arguments; function f() { arguments = 5; }"},
-
-      {1, "", "const arguments = 5;"},
-      {1, "", "if (true) { const arguments = 5; }"},
-      {1, "", "const arguments = 5; function f() { arguments; }"},
+      {"", "var arguments;"},
+      {"", "var arguments; arguments = 5;"},
+      {"", "if (true) { var arguments; }"},
+      {"", "if (true) { var arguments; arguments = 5; }"},
+      {"", "var arguments; function f() { arguments; }"},
+      {"", "var arguments; arguments = 5; function f() { arguments; }"},
+      {"", "var arguments; function f() { arguments = 5; }"},
+
+      {"", "let arguments;"},
+      {"", "let arguments; arguments = 5;"},
+      {"", "if (true) { let arguments; }"},
+      {"", "if (true) { let arguments; arguments = 5; }"},
+      {"", "let arguments; function f() { arguments; }"},
+      {"", "let arguments; arguments = 5; function f() { arguments; }"},
+      {"", "let arguments; function f() { arguments = 5; }"},
+
+      {"", "const arguments = 5;"},
+      {"", "if (true) { const arguments = 5; }"},
+      {"", "const arguments = 5; function f() { arguments; }"},
 
       // Destructuring declarations.
-      {1, "", "var [var1, var2] = [1, 2];"},
-      {1, "", "var [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
-      {1, "", "var [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
-      {1, "", "var [var1, ...var2] = [1, 2, 3];"},
-
-      {1, "", "var {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
-      {1, "",
+      {"", "var [var1, var2] = [1, 2];"},
+      {"", "var [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
+      {"", "var [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
+      {"", "var [var1, ...var2] = [1, 2, 3];"},
+
+      {"", "var {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
+      {"",
        "var {var1: var2, var3: {var4: var5}} = {var1: 1, var3: {var4: 2}};"},
-      {1, "",
-       "var {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2, 3]};"},
-
-      {1, "", "let [var1, var2] = [1, 2];"},
-      {1, "", "let [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
-      {1, "", "let [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
-      {1, "", "let [var1, ...var2] = [1, 2, 3];"},
-
-      {1, "", "let {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
-      {1, "",
+      {"", "var {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2, 3]};"},
+
+      {"", "let [var1, var2] = [1, 2];"},
+      {"", "let [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
+      {"", "let [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
+      {"", "let [var1, ...var2] = [1, 2, 3];"},
+
+      {"", "let {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
+      {"",
        "let {var1: var2, var3: {var4: var5}} = {var1: 1, var3: {var4: 2}};"},
-      {1, "",
-       "let {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2, 3]};"},
-
-      {1, "", "const [var1, var2] = [1, 2];"},
-      {1, "", "const [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
-      {1, "", "const [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
-      {1, "", "const [var1, ...var2] = [1, 2, 3];"},
-
-      {1, "", "const {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
-      {1, "",
+      {"", "let {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2, 3]};"},
+
+      {"", "const [var1, var2] = [1, 2];"},
+      {"", "const [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
+      {"", "const [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
+      {"", "const [var1, ...var2] = [1, 2, 3];"},
+
+      {"", "const {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
+      {"",
        "const {var1: var2, var3: {var4: var5}} = {var1: 1, var3: {var4: 2}};"},
-      {1, "",
-       "const {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2, 3]};"},
+      {"", "const {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2,
3]};"},
 
       // Referencing the function variable.
-      {1, "", "inner;"},
-      {1, "", "function f1() { f1; }"},
-      {1, "", "function f1() { inner; }"},
-      {1, "", "function f1() { function f2() { f1; } }"},
-      {1, "", "function arguments() {}"},
-      {1, "", "function f1() {} function f1() {}"},
-      {1, "", "va…
(message too large)

[Michael Hablich, 2017-02-07 19:37:42]

The CQ bit was checked by hablich@chromium.org

[commit-bot: I haz the power, 2017-02-07 19:37:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:38:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 19:38:04]

Failed to apply patch for test/cctest/parsing/test-preparser.cc:
While running git apply --index -p1;
  error: patch failed: test/cctest/parsing/test-preparser.cc:30
  error: test/cctest/parsing/test-preparser.cc: patch does not apply

Patch:       test/cctest/parsing/test-preparser.cc
Index: test/cctest/parsing/test-preparser.cc
diff --git a/test/cctest/parsing/test-preparser.cc
b/test/cctest/parsing/test-preparser.cc
index
be9bd8512d5c6f7b7a3b029def05cd55fb09c01b..07c270de27e2cfda040c2982228c0b7b8a22618a
100644
--- a/test/cctest/parsing/test-preparser.cc
+++ b/test/cctest/parsing/test-preparser.cc
@@ -30,274 +30,268 @@
   const char* eager_inner = "(function inner(%s) { %s })()";
 
   struct {
-    bool precise_maybe_assigned;
     const char* params;
     const char* source;
   } inners[] = {
       // Simple cases
-      {1, "", "var1;"},
-      {1, "", "var1 = 5;"},
-      {1, "", "if (true) {}"},
-      {1, "", "function f1() {}"},
+      {"", "var1;"},
+      {"", "var1 = 5;"},
+      {"", "if (true) {}"},
+      {"", "function f1() {}"},
 
       // Var declarations and assignments.
-      {1, "", "var var1;"},
-      {1, "", "var var1; var1 = 5;"},
-      {0, "", "if (true) { var var1; }"},
-      {1, "", "if (true) { var var1; var1 = 5; }"},
-      {1, "", "var var1; function f() { var1; }"},
-      {1, "", "var var1; var1 = 5; function f() { var1; }"},
-      {1, "", "var var1; function f() { var1 = 5; }"},
+      {"", "var var1;"},
+      {"", "var var1; var1 = 5;"},
+      {"", "if (true) { var var1; }"},
+      {"", "if (true) { var var1; var1 = 5; }"},
+      {"", "var var1; function f() { var1; }"},
+      {"", "var var1; var1 = 5; function f() { var1; }"},
+      {"", "var var1; function f() { var1 = 5; }"},
 
       // Let declarations and assignments.
-      {1, "", "let var1;"},
-      {1, "", "let var1; var1 = 5;"},
-      {1, "", "if (true) { let var1; }"},
-      {1, "", "if (true) { let var1; var1 = 5; }"},
-      {1, "", "let var1; function f() { var1; }"},
-      {1, "", "let var1; var1 = 5; function f() { var1; }"},
-      {1, "", "let var1; function f() { var1 = 5; }"},
+      {"", "let var1;"},
+      {"", "let var1; var1 = 5;"},
+      {"", "if (true) { let var1; }"},
+      {"", "if (true) { let var1; var1 = 5; }"},
+      {"", "let var1; function f() { var1; }"},
+      {"", "let var1; var1 = 5; function f() { var1; }"},
+      {"", "let var1; function f() { var1 = 5; }"},
 
       // Const declarations.
-      {1, "", "const var1 = 5;"},
-      {1, "", "if (true) { const var1 = 5; }"},
-      {1, "", "const var1 = 5; function f() { var1; }"},
+      {"", "const var1 = 5;"},
+      {"", "if (true) { const var1 = 5; }"},
+      {"", "const var1 = 5; function f() { var1; }"},
 
       // Redeclarations.
-      {1, "", "var var1; var var1;"},
-      {1, "", "var var1; var var1; var1 = 5;"},
-      {1, "", "var var1; if (true) { var var1; }"},
-      {1, "", "if (true) { var var1; var var1; }"},
-      {1, "", "var var1; if (true) { var var1; var1 = 5; }"},
-      {1, "", "if (true) { var var1; var var1; var1 = 5; }"},
-      {1, "", "var var1; var var1; function f() { var1; }"},
-      {1, "", "var var1; var var1; function f() { var1 = 5; }"},
+      {"", "var var1; var var1;"},
+      {"", "var var1; var var1; var1 = 5;"},
+      {"", "var var1; if (true) { var var1; }"},
+      {"", "if (true) { var var1; var var1; }"},
+      {"", "var var1; if (true) { var var1; var1 = 5; }"},
+      {"", "if (true) { var var1; var var1; var1 = 5; }"},
+      {"", "var var1; var var1; function f() { var1; }"},
+      {"", "var var1; var var1; function f() { var1 = 5; }"},
 
       // Shadowing declarations.
-      {1, "", "var var1; if (true) { var var1; }"},
-      {1, "", "var var1; if (true) { let var1; }"},
-      {1, "", "let var1; if (true) { let var1; }"},
-
-      {1, "", "var var1; if (true) { const var1 = 0; }"},
-      {1, "", "const var1 = 0; if (true) { const var1 = 0; }"},
+      {"", "var var1; if (true) { var var1; }"},
+      {"", "var var1; if (true) { let var1; }"},
+      {"", "let var1; if (true) { let var1; }"},
+
+      {"", "var var1; if (true) { const var1 = 0; }"},
+      {"", "const var1 = 0; if (true) { const var1 = 0; }"},
 
       // Arguments and this.
-      {1, "", "arguments;"},
-      {1, "", "arguments = 5;"},
-      {1, "", "if (true) { arguments; }"},
-      {1, "", "if (true) { arguments = 5; }"},
-      {1, "", "function f() { arguments; }"},
-      {1, "", "function f() { arguments = 5; }"},
-
-      {1, "", "this;"},
-      {1, "", "if (true) { this; }"},
-      {1, "", "function f() { this; }"},
+      {"", "arguments;"},
+      {"", "arguments = 5;"},
+      {"", "if (true) { arguments; }"},
+      {"", "if (true) { arguments = 5; }"},
+      {"", "function f() { arguments; }"},
+      {"", "function f() { arguments = 5; }"},
+
+      {"", "this;"},
+      {"", "if (true) { this; }"},
+      {"", "function f() { this; }"},
 
       // Variable called "arguments"
-      {1, "", "var arguments;"},
-      {1, "", "var arguments; arguments = 5;"},
-      {0, "", "if (true) { var arguments; }"},
-      {1, "", "if (true) { var arguments; arguments = 5; }"},
-      {1, "", "var arguments; function f() { arguments; }"},
-      {1, "", "var arguments; arguments = 5; function f() { arguments; }"},
-      {1, "", "var arguments; function f() { arguments = 5; }"},
-
-      {1, "", "let arguments;"},
-      {1, "", "let arguments; arguments = 5;"},
-      {1, "", "if (true) { let arguments; }"},
-      {1, "", "if (true) { let arguments; arguments = 5; }"},
-      {1, "", "let arguments; function f() { arguments; }"},
-      {1, "", "let arguments; arguments = 5; function f() { arguments; }"},
-      {1, "", "let arguments; function f() { arguments = 5; }"},
-
-      {1, "", "const arguments = 5;"},
-      {1, "", "if (true) { const arguments = 5; }"},
-      {1, "", "const arguments = 5; function f() { arguments; }"},
+      {"", "var arguments;"},
+      {"", "var arguments; arguments = 5;"},
+      {"", "if (true) { var arguments; }"},
+      {"", "if (true) { var arguments; arguments = 5; }"},
+      {"", "var arguments; function f() { arguments; }"},
+      {"", "var arguments; arguments = 5; function f() { arguments; }"},
+      {"", "var arguments; function f() { arguments = 5; }"},
+
+      {"", "let arguments;"},
+      {"", "let arguments; arguments = 5;"},
+      {"", "if (true) { let arguments; }"},
+      {"", "if (true) { let arguments; arguments = 5; }"},
+      {"", "let arguments; function f() { arguments; }"},
+      {"", "let arguments; arguments = 5; function f() { arguments; }"},
+      {"", "let arguments; function f() { arguments = 5; }"},
+
+      {"", "const arguments = 5;"},
+      {"", "if (true) { const arguments = 5; }"},
+      {"", "const arguments = 5; function f() { arguments; }"},
 
       // Destructuring declarations.
-      {1, "", "var [var1, var2] = [1, 2];"},
-      {1, "", "var [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
-      {1, "", "var [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
-      {1, "", "var [var1, ...var2] = [1, 2, 3];"},
-
-      {1, "", "var {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
-      {1, "",
+      {"", "var [var1, var2] = [1, 2];"},
+      {"", "var [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
+      {"", "var [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
+      {"", "var [var1, ...var2] = [1, 2, 3];"},
+
+      {"", "var {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
+      {"",
        "var {var1: var2, var3: {var4: var5}} = {var1: 1, var3: {var4: 2}};"},
-      {1, "",
-       "var {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2, 3]};"},
-
-      {1, "", "let [var1, var2] = [1, 2];"},
-      {1, "", "let [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
-      {1, "", "let [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
-      {1, "", "let [var1, ...var2] = [1, 2, 3];"},
-
-      {1, "", "let {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
-      {1, "",
+      {"", "var {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2, 3]};"},
+
+      {"", "let [var1, var2] = [1, 2];"},
+      {"", "let [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
+      {"", "let [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
+      {"", "let [var1, ...var2] = [1, 2, 3];"},
+
+      {"", "let {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
+      {"",
        "let {var1: var2, var3: {var4: var5}} = {var1: 1, var3: {var4: 2}};"},
-      {1, "",
-       "let {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2, 3]};"},
-
-      {1, "", "const [var1, var2] = [1, 2];"},
-      {1, "", "const [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
-      {1, "", "const [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
-      {1, "", "const [var1, ...var2] = [1, 2, 3];"},
-
-      {1, "", "const {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
-      {1, "",
+      {"", "let {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2, 3]};"},
+
+      {"", "const [var1, var2] = [1, 2];"},
+      {"", "const [var1, var2, [var3, var4]] = [1, 2, [3, 4]];"},
+      {"", "const [{var1: var2}, {var3: var4}] = [{var1: 1}, {var3: 2}];"},
+      {"", "const [var1, ...var2] = [1, 2, 3];"},
+
+      {"", "const {var1: var2, var3: var4} = {var1: 1, var3: 2};"},
+      {"",
        "const {var1: var2, var3: {var4: var5}} = {var1: 1, var3: {var4: 2}};"},
-      {1, "",
-       "const {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2, 3]};"},
+      {"", "const {var1: var2, var3: [var4, var5]} = {var1: 1, var3: [2,
3]};"},
 
       // Referencing the function variable.
-      {1, "", "inner;"},
-      {1, "", "function f1() { f1; }"},
-      {1, "", "function f1() { inner; }"},
-      {1, "", "function f1() { function f2() { f1; } }"},
-      {1, "", "function arguments() {}"},
-      {1, "", "function f1() {} function f1() {}"},
-      {1, "", "va…
(message too large)

[Michael Hablich, 2017-02-07 19:40:09]

The CQ bit was checked by hablich@chromium.org

[commit-bot: I haz the power, 2017-02-07 19:40:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:40:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486496409709500, "parent_rev":
"8ee52241e2d89c2deab4263309cd09d4fbe1e918", "commit_rev":
"f3ae5ccf57690d8c2d87c4fe1d10b103ad6a4ab3"}

[commit-bot: I haz the power, 2017-02-07 19:40:32]

Description was changed from

==========
Revert of [parsing] Fix maybe-assigned for loop variables. (patchset #3 id:40001
of https://codereview.chromium.org/2673403003/ )

Reason for revert:
Speculative revert because of https://codereview.chromium.org/2679163002/.

Original issue's description:
> [parsing] Fix maybe-assigned for loop variables.
> 
> Due to hoisting, the value of a 'var'-declared variable may actually change
even
> if the code contains only the "initial" assignment, namely when that
assignment
> occurs inside a loop.  For example:
> 
>   let i = 10;
>   do { var x = i } while (i--):
> 
> As a simple and very conservative approximation of this, we explicitly mark
> as maybe-assigned any non-lexical variable whose "declaration" does not
> syntactically occur in the function scope.  (In the example above, it
> occurs in a block scope.)
> 
> BUG=v8:5636
> 
> Review-Url: https://codereview.chromium.org/2673403003
> Cr-Commit-Position: refs/heads/master@{#42989}
> Committed:
https://chromium.googlesource.com/v8/v8/+/a33fcd663b28b8846e12b97c30d6e7d8377...

TBR=marja@chromium.org,adamk@chromium.org,neis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5636
==========

to

==========
Revert of [parsing] Fix maybe-assigned for loop variables. (patchset #3 id:40001
of https://codereview.chromium.org/2673403003/ )

Reason for revert:
Speculative revert because of https://codereview.chromium.org/2679163002/.

Original issue's description:
> [parsing] Fix maybe-assigned for loop variables.
> 
> Due to hoisting, the value of a 'var'-declared variable may actually change
even
> if the code contains only the "initial" assignment, namely when that
assignment
> occurs inside a loop.  For example:
> 
>   let i = 10;
>   do { var x = i } while (i--):
> 
> As a simple and very conservative approximation of this, we explicitly mark
> as maybe-assigned any non-lexical variable whose "declaration" does not
> syntactically occur in the function scope.  (In the example above, it
> occurs in a block scope.)
> 
> BUG=v8:5636
> 
> Review-Url: https://codereview.chromium.org/2673403003
> Cr-Commit-Position: refs/heads/master@{#42989}
> Committed:
https://chromium.googlesource.com/v8/v8/+/a33fcd663b28b8846e12b97c30d6e7d8377...

TBR=marja@chromium.org,adamk@chromium.org,neis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5636

Review-Url: https://codereview.chromium.org/2679263002
Cr-Commit-Position: refs/heads/master@{#43010}
Committed:
https://chromium.googlesource.com/v8/v8/+/f3ae5ccf57690d8c2d87c4fe1d10b103ad6...
==========

[commit-bot: I haz the power, 2017-02-07 19:40:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f3ae5ccf57690d8c2d87c4fe1d10b103ad6...

[Michael Hablich, 2017-02-07 20:42:23]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2686663002/ by hablich@chromium.org.

The reason for reverting is: False alarm, bot hiccup.