Chromium Code Reviews
DescriptionRevert of Use a new Supplement constructor for ServiceWorkerRegistration supplements (patchset #2 id:20001 of https://codereview.chromium.org/2651613002/ )
Reason for revert:
This seems causing test failures on Leak bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/2077
6 tests failed:
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html ( Code Search )
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html ( Code Search )
fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html ( Code Search )
fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html ( Code Search )
fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html ( Code Search )
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html ( Code Search )
Original issue's description:
> Use a new Supplement constructor for ServiceWorkerRegistration supplements
>
> This is a step to deprecate the default constructor of Supplement<>.
> Also this CL removes Member<ServiceWorkerRegistration>.
>
> BUG=610176
>
> Review-Url: https://codereview.chromium.org/2651613002
> Cr-Commit-Position: refs/heads/master@{#448582}
> Committed: https://chromium.googlesource.com/chromium/src/+/73d601815cebdd38fc5248d62ed884477c9e0972
TBR=sigbjornf@opera.com,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610176
Review-Url: https://codereview.chromium.org/2686613004
Cr-Commit-Position: refs/heads/master@{#448910}
Committed: https://chromium.googlesource.com/chromium/src/+/989cdc24a5db94cc5e58edee85293528a852726b
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|