Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2686613004: Revert of Use a new Supplement constructor for ServiceWorkerRegistration supplements (Closed)

Created:
3 years, 10 months ago by shimazu
Modified:
3 years, 10 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, Peter Beverloo, awdf+watch_chromium.org, rouslan+payments_chromium.org, iclelland+watch_chromium.org, johnme+watch_chromium.org, serviceworker-reviews, chasej+watch_chromium.org, nhiroki, gogerald+paymentswatch_chromium.org, tzik, kinuko+serviceworker, jkarlin+watch_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, shimazu+serviceworker_chromium.org, harkness+watch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use a new Supplement constructor for ServiceWorkerRegistration supplements (patchset #2 id:20001 of https://codereview.chromium.org/2651613002/ ) Reason for revert: This seems causing test failures on Leak bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/2077 6 tests failed: fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html ( Code Search ) fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html ( Code Search ) fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html ( Code Search ) fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html ( Code Search ) fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html ( Code Search ) fast/dom/Window/property-access-on-cached-window-after-frame-removed.html ( Code Search ) Original issue's description: > Use a new Supplement constructor for ServiceWorkerRegistration supplements > > This is a step to deprecate the default constructor of Supplement<>. > Also this CL removes Member<ServiceWorkerRegistration>. > > BUG=610176 > > Review-Url: https://codereview.chromium.org/2651613002 > Cr-Commit-Position: refs/heads/master@{#448582} > Committed: https://chromium.googlesource.com/chromium/src/+/73d601815cebdd38fc5248d62ed884477c9e0972 TBR=sigbjornf@opera.com,haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=610176 Review-Url: https://codereview.chromium.org/2686613004 Cr-Commit-Position: refs/heads/master@{#448910} Committed: https://chromium.googlesource.com/chromium/src/+/989cdc24a5db94cc5e58edee85293528a852726b

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
shimazu
Created Revert of Use a new Supplement constructor for ServiceWorkerRegistration supplements
3 years, 10 months ago (2017-02-08 05:08:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686613004/1
3 years, 10 months ago (2017-02-08 05:08:40 UTC) #3
haraken
LGTM to revert, thanks.
3 years, 10 months ago (2017-02-08 05:09:18 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 05:10:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/989cdc24a5db94cc5e58edee8529...

Powered by Google App Engine
This is Rietveld 408576698