[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:unit_tests to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Marked observer in card_set_unittest.mm as weak.
Removed [[tab retain] autorelease]; in card set unittest.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2686573003
Cr-Commit-Position: refs/heads/master@{#449310}
Committed: https://chromium.googlesource.com/chromium/src/+/26b0c294dd46ece57188e67ebef70db4a450d45b

[lody, 2017-02-07 15:20:07]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 15:20:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lody, 2017-02-07 15:26:01]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 15:26:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lody, 2017-02-07 16:11:38]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Marked observer in card_set_unittest.mm as weak.
BUG=624363
TEST=None
==========

[lody, 2017-02-07 16:12:16]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Marked observer in card_set_unittest.mm as weak.
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Marked observer in card_set_unittest.mm as weak.
Removed [[tab retain] autorelease]; in card set unittest.
BUG=624363
TEST=None
==========

[lody, 2017-02-07 16:12:37]

lod@chromium.org changed reviewers:
+ sdefresne@chromium.org, stkhapugin@chromium.org

[lody, 2017-02-07 16:12:37]

Please review, thanks

[commit-bot: I haz the power, 2017-02-07 16:41:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 16:41:22]

Dry run: This issue passed the CQ dry run.

[lody, 2017-02-08 14:47:34]

ping

[sdefresne, 2017-02-09 13:47:50]

lgtm with lots of nits

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm
(right):

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm:119:
StackCard* card = (StackCard*)[[MockStackCard alloc] init];
nit: please change this to use a static_cast:

  StackCard* card = static_cast<StackCard*>([[MockStackCard alloc] init]);

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm:140:
StackCard* view1 = (StackCard*)[[MockStackCard alloc] init];
ditto x 3

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm:178:
StackCard* card = (StackCard*)[[UIView alloc] initWithFrame:cardFrame];
ditto

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm:190:
StackCard* card = (StackCard*)[[MockStackCard alloc] init];
ditto

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/stack_view/stack_card_unittest.mm (right):

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/stack_card_unittest.mm:32: return
(CardView*)[[MockCardView alloc] initWithFrame:frame];
static_cast

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/stack_card_unittest.mm:45: 
PlatformTest drain it's autoreleasepool in ShutDown(), so either set
view_provider_ in ShutDown if necessary, or just change the initialisation to
happen in the constructor.

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm (right):

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm:119:
initWithMainCardSet:(CardSet*)main_card_set_
static_cast

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm:208:
EXPECT_EQ((CardSet*)otr_card_set_, [view_controller_ inactiveCardSet]);
static_cast

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm:211:
EXPECT_EQ((CardSet*)main_card_set_, [view_controller_ inactiveCardSet]);
ditto

[lody, 2017-02-09 14:48:52]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 14:49:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 15:59:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 15:59:28]

Dry run: This issue passed the CQ dry run.

[lody, 2017-02-09 16:00:04]

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm
(right):

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm:119:
StackCard* card = (StackCard*)[[MockStackCard alloc] init];
On 2017/02/09 13:47:49, sdefresne wrote:
> nit: please change this to use a static_cast:
> 
>   StackCard* card = static_cast<StackCard*>([[MockStackCard alloc] init]);

Done.

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm:140:
StackCard* view1 = (StackCard*)[[MockStackCard alloc] init];
On 2017/02/09 13:47:49, sdefresne wrote:
> ditto x 3

Done.

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm:178:
StackCard* card = (StackCard*)[[UIView alloc] initWithFrame:cardFrame];
On 2017/02/09 13:47:49, sdefresne wrote:
> ditto

Done.

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm:190:
StackCard* card = (StackCard*)[[MockStackCard alloc] init];
On 2017/02/09 13:47:49, sdefresne wrote:
> ditto

Done.

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/stack_view/stack_card_unittest.mm (right):

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/stack_card_unittest.mm:32: return
(CardView*)[[MockCardView alloc] initWithFrame:frame];
On 2017/02/09 13:47:49, sdefresne wrote:
> static_cast

Done.

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/stack_card_unittest.mm:45: 
On 2017/02/09 13:47:49, sdefresne wrote:
> PlatformTest drain it's autoreleasepool in ShutDown(), so either set
> view_provider_ in ShutDown if necessary, or just change the initialisation to
> happen in the constructor.

Done.

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm (right):

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm:119:
initWithMainCardSet:(CardSet*)main_card_set_
On 2017/02/09 13:47:50, sdefresne wrote:
> static_cast

Done.

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm:208:
EXPECT_EQ((CardSet*)otr_card_set_, [view_controller_ inactiveCardSet]);
On 2017/02/09 13:47:50, sdefresne wrote:
> static_cast

Done.

https://codereview.chromium.org/2686573003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm:211:
EXPECT_EQ((CardSet*)main_card_set_, [view_controller_ inactiveCardSet]);
On 2017/02/09 13:47:50, sdefresne wrote:
> ditto

Done.

[lody, 2017-02-09 16:21:26]

The CQ bit was checked by lod@chromium.org

[lody, 2017-02-09 16:21:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2686573003/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2017-02-09 16:21:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 16:26:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486657286328030,
"parent_rev": "bdda32bf23c89798aac0597de04148572eb8fb07", "commit_rev":
"26b0c294dd46ece57188e67ebef70db4a450d45b"}

[commit-bot: I haz the power, 2017-02-09 16:26:59]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Marked observer in card_set_unittest.mm as weak.
Removed [[tab retain] autorelease]; in card set unittest.
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Marked observer in card_set_unittest.mm as weak.
Removed [[tab retain] autorelease]; in card set unittest.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2686573003
Cr-Commit-Position: refs/heads/master@{#449310}
Committed:
https://chromium.googlesource.com/chromium/src/+/26b0c294dd46ece57188e67ebef7...
==========

[commit-bot: I haz the power, 2017-02-09 16:27:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/26b0c294dd46ece57188e67ebef7...