[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:unit_tests to ARC.

ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <QuartzCore/QuartzCore.h>
 
 #include "base/logging.h"
-#include "base/mac/scoped_nsautorelease_pool.h"
-#include "base/mac/scoped_nsobject.h"
 #import "ios/chrome/browser/tabs/tab_model.h"
 #import "ios/chrome/browser/ui/stack_view/card_set.h"
 #import "ios/chrome/browser/ui/stack_view/stack_card.h"
 #import "ios/chrome/browser/ui/stack_view/stack_view_controller.h"
 #import "ios/chrome/browser/ui/stack_view/stack_view_controller_private.h"
 #include "ios/chrome/test/block_cleanup_test.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/gtest_mac.h"
 #include "third_party/ocmock/OCMock/OCMock.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 
 const CGFloat kViewportDimension = 200;
 
 }  // namespace
 
 #pragma mark -
 
 @interface MockCardSet : NSObject {
  @private
   UIView* displayView_;
   CGSize cardSize_;
   CGFloat layoutAxisPosition_;
   BOOL initialConfigurationSet_;
-  id observer_;
 }
 
 // CardSet simulation
-@property(nonatomic, retain, readwrite) UIView* displayView;
+@property(nonatomic, strong, readwrite) UIView* displayView;
 @property(nonatomic, assign, readwrite) CGSize cardSize;
-@property(nonatomic, assign, readwrite) id<CardSetObserver> observer;
+@property(nonatomic, weak, readwrite) id<CardSetObserver> observer;
 @property(nonatomic, assign, readwrite) BOOL keepOnlyVisibleCardViewsAlive;
 
 - (void)configureLayoutParametersWithMargin:(CGFloat)margin;
 - (void)setLayoutAxisPosition:(CGFloat)position
                    isVertical:(BOOL)layoutIsVertical;
 - (void)clearGestureRecognizerTargetAndDelegateFromCards:(id)object;
 - (NSArray*)cards;
 - (CGFloat)maximumStackLength;
 - (void)displayViewSizeWasChanged;
 - (TabModel*)tabModel;
@@ skipping 53 matching lines @@
 
 #pragma mark -
 
 namespace {
 
 class StackViewControllerTest : public BlockCleanupTest {
  protected:
   void SetUp() override {
     BlockCleanupTest::SetUp();
 
-    main_card_set_.reset([[MockCardSet alloc] init]);
-    otr_card_set_.reset([[MockCardSet alloc] init]);
+    main_card_set_ = [[MockCardSet alloc] init];
+    otr_card_set_ = [[MockCardSet alloc] init];
 
-    view_controller_.reset([[StackViewController alloc]
-        initWithMainCardSet:(CardSet*)main_card_set_.get()
-                 otrCardSet:(CardSet*)otr_card_set_.get()
-              activeCardSet:(CardSet*)main_card_set_.get()]);
+    view_controller_ = [[StackViewController alloc]
+        initWithMainCardSet:(CardSet*)main_card_set_

[sdefresne, 2017/02/09 13:47:50]

static_cast

[lody, 2017/02/09 16:00:03]

Done.

+                 otrCardSet:(CardSet*)otr_card_set_
+              activeCardSet:(CardSet*)main_card_set_];
     // Resize the view and call VC lifecycle events
     [view_controller_ view].frame =
         CGRectMake(0.0, 0.0, kViewportDimension, kViewportDimension);
     // Simulate displaying the view.
     [view_controller_ viewWillAppear:NO];
   }
   void TearDown() override {
     // The view controller uses a delayed selector call, so in the unittests
     // that causes the controller to be retained and outlive the test.
-    [NSObject cancelPreviousPerformRequestsWithTarget:view_controller_.get()];
+    [NSObject cancelPreviousPerformRequestsWithTarget:view_controller_];
     // And there are likely animations still running.
     for (UIView* view in [[view_controller_ scrollView] subviews]) {
       // Remove any animations on cards themselves.
       for (UIView* subview in [view subviews]) {
         [subview.layer removeAllAnimations];
       }
       [view.layer removeAllAnimations];
     }
     [[[view_controller_ scrollView] layer] removeAllAnimations];
 
@@ skipping 35 matching lines @@
     } else {
       EXPECT_FLOAT_EQ(display_view_origin.x, content_offset);
       EXPECT_FLOAT_EQ(display_view_origin.y, 0);
       EXPECT_GT([[view_controller_ scrollView] contentSize].width,
                 [card_set maximumStackLength]);
       EXPECT_FLOAT_EQ(card_set.displayView.bounds.size.height,
                       [[view_controller_ scrollView] contentSize].height);
     }
   }
 
-  base::scoped_nsobject<StackViewController> view_controller_;
-  base::scoped_nsobject<MockCardSet> main_card_set_;
-  base::scoped_nsobject<MockCardSet> otr_card_set_;
+  StackViewController* view_controller_;
+  MockCardSet* main_card_set_;
+  MockCardSet* otr_card_set_;
 };
 
 TEST_F(StackViewControllerTest, BasicConfiguration) {
   // Ensure that the CardSet is configured and correctly laid out.
   EXPECT_TRUE([main_card_set_ configured]);
   EXPECT_TRUE([otr_card_set_ configured]);
   ValidateDisplaySetupForCardSet(main_card_set_);
   ValidateDisplaySetupForCardSet(otr_card_set_);
   EXPECT_GT([main_card_set_ cardSize].width, 0U);
   EXPECT_GT([main_card_set_ cardSize].height, 0U);
 
   // Incognito should always be right of (or below in landscape) the main set.
   EXPECT_GT([otr_card_set_ layoutAxisPosition],
             [main_card_set_ layoutAxisPosition]);
 }
 
 TEST_F(StackViewControllerTest, IncognitoHandling) {
   EXPECT_FALSE([view_controller_ isCurrentSetIncognito]);
-  EXPECT_EQ((CardSet*)otr_card_set_.get(), [view_controller_ inactiveCardSet]);
+  EXPECT_EQ((CardSet*)otr_card_set_, [view_controller_ inactiveCardSet]);

[sdefresne, 2017/02/09 13:47:50]

static_cast

[lody, 2017/02/09 16:00:03]

Done.

   [view_controller_ setActiveCardSet:[view_controller_ inactiveCardSet]];
   EXPECT_TRUE([view_controller_ isCurrentSetIncognito]);
-  EXPECT_EQ((CardSet*)main_card_set_.get(), [view_controller_ inactiveCardSet]);
+  EXPECT_EQ((CardSet*)main_card_set_, [view_controller_ inactiveCardSet]);

[sdefresne, 2017/02/09 13:47:50]

ditto

[lody, 2017/02/09 16:00:03]

Done.

   // Incognito should always be right of (or below in landscape) the main set.
   EXPECT_GT([otr_card_set_ layoutAxisPosition],
             [main_card_set_ layoutAxisPosition]);
 }
 
 TEST_F(StackViewControllerTest, ScrollViewContentOffsetRecentering) {
   BOOL is_portrait = UIInterfaceOrientationIsPortrait(
       [UIApplication sharedApplication].statusBarOrientation);
   CGFloat scroll_view_breadth =
       is_portrait ? [[view_controller_ scrollView] contentSize].width
@@ skipping 32 matching lines @@
   ValidateDisplaySetupForCardSet(otr_card_set_);
 }
 
 TEST_F(StackViewControllerTest, TabModelReset) {
   [view_controller_ setOtrTabModel:nil];
   ValidateDisplaySetupForCardSet(main_card_set_);
   ValidateDisplaySetupForCardSet(otr_card_set_);
 }
 
 }  // namespace