Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2686533004: Use pixel coordinates for shadow underlay bounds (Closed)

Created:
3 years, 10 months ago by oshima
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Use pixel coordinates for shadow underlay bounds * Introduced new request set_rectangular_surface_shadow. Reprecated old one. * Added placeholder for set/unset moving introduced in remote_surface version 2. This only switches the underlay to pixel and that looks good enough to me. I'll work on the shadow itself separately if necessary. BUG=687742 TEST=tested on Elm. Review-Url: https://codereview.chromium.org/2664403004 Cr-Commit-Position: refs/heads/master@{#448549} (cherry picked from commit ba48072770ed46f3328f09d8147f42c8cf4a1677) Review-Url: https://codereview.chromium.org/2686533004 . Cr-Commit-Position: refs/branch-heads/2987@{#391} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/97bbe761db423525796e492d568e0ebc64af6b24

Patch Set 1 #

Patch Set 2 : remove unnecessary changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -90 lines) Patch
M components/exo/shell_surface.h View 1 3 chunks +14 lines, -4 lines 0 comments Download
M components/exo/shell_surface.cc View 1 5 chunks +48 lines, -17 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 1 13 chunks +125 lines, -36 lines 0 comments Download
M components/exo/wayland/server.cc View 6 chunks +41 lines, -14 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h View 5 chunks +89 lines, -5 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h View 6 chunks +69 lines, -3 lines 0 comments Download
M third_party/wayland-protocols/protocol/remote-shell-protocol.c View 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml View 5 chunks +71 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
oshima
3 years, 10 months ago (2017-02-08 19:48:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:80001) manually as
97bbe761db423525796e492d568e0ebc64af6b24.

Powered by Google App Engine
This is Rietveld 408576698