Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2686503002: [Sensors] Return 'NotReadableError' exception if failed to find a sensor (Closed)

Created:
3 years, 10 months ago by Mikhail
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews, haraken, wanming.lin, shalamov, Mikhail, Reilly Grant (use Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Return 'NotReadableError' exception if failed to find a sensor As described at https://w3c.github.io/sensors/#connect-to-sensor BUG=606766 Review-Url: https://codereview.chromium.org/2686503002 Cr-Commit-Position: refs/heads/master@{#448612} Committed: https://chromium.googlesource.com/chromium/src/+/255943ab0b52ece4966d4cc651ff0ace0aa800ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Mikhail
PTAL
3 years, 10 months ago (2017-02-07 10:55:40 UTC) #4
shalamov
lgtm
3 years, 10 months ago (2017-02-07 10:59:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686503002/1
3 years, 10 months ago (2017-02-07 13:24:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/255943ab0b52ece4966d4cc651ff0ace0aa800ed
3 years, 10 months ago (2017-02-07 13:28:43 UTC) #12
Reilly Grant (use Gerrit)
3 years, 10 months ago (2017-02-08 01:55:55 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698