Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: third_party/WebKit/Source/modules/sensor/SensorProxy.cpp

Issue 2686503002: [Sensors] Return 'NotReadableError' exception if failed to find a sensor (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/sensor/SensorProxy.h" 5 #include "modules/sensor/SensorProxy.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/frame/LocalFrame.h" 8 #include "core/frame/LocalFrame.h"
9 #include "modules/sensor/SensorProviderProxy.h" 9 #include "modules/sensor/SensorProviderProxy.h"
10 #include "modules/sensor/SensorReadingUpdater.h" 10 #include "modules/sensor/SensorReadingUpdater.h"
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 m_clientBinding.Close(); 183 m_clientBinding.Close();
184 184
185 for (Observer* observer : m_observers) 185 for (Observer* observer : m_observers)
186 observer->onSensorError(code, sanitizedMessage, unsanitizedMessage); 186 observer->onSensorError(code, sanitizedMessage, unsanitizedMessage);
187 } 187 }
188 188
189 void SensorProxy::onSensorCreated(SensorInitParamsPtr params, 189 void SensorProxy::onSensorCreated(SensorInitParamsPtr params,
190 SensorClientRequest clientRequest) { 190 SensorClientRequest clientRequest) {
191 DCHECK_EQ(Initializing, m_state); 191 DCHECK_EQ(Initializing, m_state);
192 if (!params) { 192 if (!params) {
193 handleSensorError(NotFoundError, "Sensor is not present on the platform."); 193 handleSensorError(NotReadableError,
194 "Sensor is not present on the platform.");
194 return; 195 return;
195 } 196 }
196 const size_t kReadBufferSize = sizeof(ReadingBuffer); 197 const size_t kReadBufferSize = sizeof(ReadingBuffer);
197 198
198 DCHECK_EQ(0u, params->buffer_offset % kReadBufferSize); 199 DCHECK_EQ(0u, params->buffer_offset % kReadBufferSize);
199 200
200 m_mode = params->mode; 201 m_mode = params->mode;
201 m_defaultConfig = std::move(params->default_configuration); 202 m_defaultConfig = std::move(params->default_configuration);
202 if (!m_defaultConfig) { 203 if (!m_defaultConfig) {
203 handleSensorError(); 204 handleSensorError();
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 const device::OneWriterSeqLock& seqlock = buffer->seqlock.value(); 270 const device::OneWriterSeqLock& seqlock = buffer->seqlock.value();
270 auto version = seqlock.ReadBegin(); 271 auto version = seqlock.ReadBegin();
271 auto readingData = buffer->reading; 272 auto readingData = buffer->reading;
272 if (seqlock.ReadRetry(version)) 273 if (seqlock.ReadRetry(version))
273 return false; 274 return false;
274 result = readingData; 275 result = readingData;
275 return true; 276 return true;
276 } 277 }
277 278
278 } // namespace blink 279 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698