Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2686163002:
Remove bad DCHECK in SkBitmapToXcursorImage (Closed)
|
Created:
3 years, 10 months ago by Charlie Harrison Modified:
3 years, 10 months ago CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, msarett1 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove bad DCHECK in SkBitmapToXcursorImage
This DCHECK can be triggered in the code, but it doesn't cause any
major problems in production. This patch removes it in favor of a TODO.
BUG=596782
Review-Url: https://codereview.chromium.org/2686163002
Cr-Commit-Position: refs/heads/master@{#451671}
Committed: https://chromium.googlesource.com/chromium/src/+/2cf716e4b8cecd7600fa3740a28fedb5269ab195
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
csharrison@chromium.org changed reviewers: + derat@chromium.org
derat: PTAL? Disclaimer: I don't know this code very well, but +msarett thought removing this was OK.
msarett@chromium.org changed reviewers: + msarett@chromium.org
lgtm
lgtm as an owner, but is whoever added this in the first place still around? it'd be good to get their take on it.
csharrison@chromium.org changed reviewers: + varunjain@chromium.org
Looks like it was varunjain who first added this code: https://chromium.googlesource.com/chromium/src/+/f54bd1779f114be16dd4b4007f1e... Added to reviewers, but it doesn't look like they still contribute to chromium.
Going to go ahead and land this, feel free to push back if anyone disagrees.
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487630161416500, "parent_rev":
"85feb87f450d2d09f304c19a3e06df6a6c2521b1", "commit_rev":
"2cf716e4b8cecd7600fa3740a28fedb5269ab195"}
Message was sent while issue was closed.
Description was changed from ========== Remove bad DCHECK in SkBitmapToXcursorImage This DCHECK can be triggered in the code, but it doesn't cause any major problems in production. This patch removes it in favor of a TODO. BUG=596782 ========== to ========== Remove bad DCHECK in SkBitmapToXcursorImage This DCHECK can be triggered in the code, but it doesn't cause any major problems in production. This patch removes it in favor of a TODO. BUG=596782 Review-Url: https://codereview.chromium.org/2686163002 Cr-Commit-Position: refs/heads/master@{#451671} Committed: https://chromium.googlesource.com/chromium/src/+/2cf716e4b8cecd7600fa3740a28f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2cf716e4b8cecd7600fa3740a28f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
