Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: ui/base/x/x11_util.cc

Issue 2686163002: Remove bad DCHECK in SkBitmapToXcursorImage (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/x/x11_util.cc
diff --git a/ui/base/x/x11_util.cc b/ui/base/x/x11_util.cc
index 43bb7d7d610769b89672e5426115a09d5d6e6231..dbb489fa84c800f3d2738e22514e997be6d4c666 100644
--- a/ui/base/x/x11_util.cc
+++ b/ui/base/x/x11_util.cc
@@ -288,7 +288,9 @@ void UnrefCustomXCursor(::Cursor cursor) {
XcursorImage* SkBitmapToXcursorImage(const SkBitmap* cursor_image,
const gfx::Point& hotspot) {
- DCHECK(cursor_image->colorType() == kN32_SkColorType);
+ // TODO(crbug.com/596782): It is possible for cursor_image to be zeroed out
+ // at this point, which leads to benign debug errors. Once this is fixed, we
+ // should DCHECK_EQ(cursor_image->colorType(), kN32_SkColorType).
gfx::Point hotspot_point = hotspot;
SkBitmap scaled;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698