Copy StyleVisualData::m_zoom in copy constructor.

Copy StyleVisualData::m_zoom in copy constructor.

Currently StyleVisualData::m_zoom is reset to the initial zoom value
every time StyleVisualData is copied using the copy constructor. There
is no indication that this is intentional.

This patch changes the code to actually copy m_zoom instead of
resetting it. We tried to obtain a repro test case by running trybots
with a DCHECK to see if the bug is reacheable, but the trybots passed.
We also tried to find the commit that introduced this, but the code is
very old and we couldn't trace its origin.

It is most likely a copy and paste error, and even if it is not, this
code is not dependable due to copy elision.

See https://codereview.chromium.org/2687533004 for more details.

BUG=689330
Review-Url: https://codereview.chromium.org/2686013002
Cr-Commit-Position: refs/heads/master@{#449451}
Committed: https://chromium.googlesource.com/chromium/src/+/24835036681c326052b092b9697333ad9f4c2a9b

[shend, 2017-02-08 22:43:32]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org, sashab@chromium.org

[shend, 2017-02-08 22:43:33]

Sasha and Alan, PTAL

[shend, 2017-02-08 23:30:16]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:30:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 01:07:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 01:07:06]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-02-09 03:13:26]

Love the verification patch -- because I don't trust our trybots, let's actually
land that one, make it a dependent patchset, then delete that line in this patch
(does that make sense?)

[alancutter (OOO until 2018), 2017-02-09 04:51:54]

lgtm

[shend, 2017-02-09 04:55:53]

Description was changed from

==========
Copy StyleVisualData::m_zoom in copy constructor.

Currently StyleVisualData::m_zoom is reset to the initial zoom value
every time StyleVisualData is copied using the copy constructor. There
is no indication that this is intentional.

This patch changes the code to actually copy m_zoom instead of
resetting it. See https://codereview.chromium.org/2687533004 for
verification.

BUG=689330
==========

to

==========
Copy StyleVisualData::m_zoom in copy constructor.

Currently StyleVisualData::m_zoom is reset to the initial zoom value
every time StyleVisualData is copied using the copy constructor. There
is no indication that this is intentional.

This patch changes the code to actually copy m_zoom instead of
resetting it. We tried to obtain a repro test case by running trybots
with a DCHECK to see if the bug is reacheable, but the trybots passed.
We also tried to find the commit that introduced this, but the code is
very old and we couldn't trace its origin.

It is most likely a copy and paste error, and even if it is not, this
code is not dependable due to copy elision.

See https://codereview.chromium.org/2687533004 for more details.

BUG=689330
==========

[sashab, 2017-02-09 04:58:10]

lgtm

[shend, 2017-02-09 21:25:59]

The CQ bit was checked by shend@chromium.org

[shend, 2017-02-09 21:26:00]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2686013002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-09 21:26:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 23:11:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486675559950190,
"parent_rev": "1e3d6c77d25e3cd97e776fa3b5427f883341c854", "commit_rev":
"24835036681c326052b092b9697333ad9f4c2a9b"}

[commit-bot: I haz the power, 2017-02-09 23:12:05]

Description was changed from

==========
Copy StyleVisualData::m_zoom in copy constructor.

Currently StyleVisualData::m_zoom is reset to the initial zoom value
every time StyleVisualData is copied using the copy constructor. There
is no indication that this is intentional.

This patch changes the code to actually copy m_zoom instead of
resetting it. We tried to obtain a repro test case by running trybots
with a DCHECK to see if the bug is reacheable, but the trybots passed.
We also tried to find the commit that introduced this, but the code is
very old and we couldn't trace its origin.

It is most likely a copy and paste error, and even if it is not, this
code is not dependable due to copy elision.

See https://codereview.chromium.org/2687533004 for more details.

BUG=689330
==========

to

==========
Copy StyleVisualData::m_zoom in copy constructor.

Currently StyleVisualData::m_zoom is reset to the initial zoom value
every time StyleVisualData is copied using the copy constructor. There
is no indication that this is intentional.

This patch changes the code to actually copy m_zoom instead of
resetting it. We tried to obtain a repro test case by running trybots
with a DCHECK to see if the bug is reacheable, but the trybots passed.
We also tried to find the commit that introduced this, but the code is
very old and we couldn't trace its origin.

It is most likely a copy and paste error, and even if it is not, this
code is not dependable due to copy elision.

See https://codereview.chromium.org/2687533004 for more details.

BUG=689330

Review-Url: https://codereview.chromium.org/2686013002
Cr-Commit-Position: refs/heads/master@{#449451}
Committed:
https://chromium.googlesource.com/chromium/src/+/24835036681c326052b092b96973...
==========

[commit-bot: I haz the power, 2017-02-09 23:12:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/24835036681c326052b092b96973...