Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2685943002: [Media>UI] Reset media session actions when navigating away (Closed)

Created:
3 years, 10 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Media>UI] Reset media session actions when navigating away There is a bug caused by media session actions being not properly reset when navigating away, so that the notification control buttons stays the same when the new page starts to play media. This CL fixes the issue. BUG=689664 Review-Url: https://codereview.chromium.org/2680103002 Cr-Commit-Position: refs/heads/master@{#449032} (cherry picked from commit e9c5df7d3be68ce0d8cf656dac0b9a1912ea5a28) Review-Url: https://codereview.chromium.org/2685943002 . Cr-Commit-Position: refs/branch-heads/2987@{#389} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/15ab0ba733d50b9f7567bd77049aafeaa9114b0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -0 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java View 1 chunk +163 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 10 months ago (2017-02-08 18:25:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
15ab0ba733d50b9f7567bd77049aafeaa9114b0b.

Powered by Google App Engine
This is Rietveld 408576698