[Media>UI] Reset media session actions when navigating away

[Media>UI] Reset media session actions when navigating away

There is a bug caused by media session actions being not properly reset
when navigating away, so that the notification control buttons stays the
same when the new page starts to play media. This CL fixes the issue.

BUG=689664
Review-Url: https://codereview.chromium.org/2680103002
Cr-Commit-Position: refs/heads/master@{#449032}
Committed: https://chromium.googlesource.com/chromium/src/+/e9c5df7d3be68ce0d8cf656dac0b9a1912ea5a28

[Zhiqiang Zhang (Slow), 2017-02-07 21:09:31]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 21:10:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhiqiang Zhang (Slow), 2017-02-07 21:10:28]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org, mariakhomenko@chromium.org

[Zhiqiang Zhang (Slow), 2017-02-07 21:10:29]

+avayvod: media
+mariakhomenko: BUILD.gn, java_sources.gni

[Maria, 2017-02-07 21:23:20]

On 2017/02/07 21:10:29, Zhiqiang Zhang wrote:
> +avayvod: media
> +mariakhomenko: BUILD.gn, java_sources.gni

lgtm for build stuff

[commit-bot: I haz the power, 2017-02-07 22:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 22:21:48]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-02-08 12:21:05]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-02-08 12:21:06]

lgtm

https://codereview.chromium.org/2680103002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
(right):

https://codereview.chromium.org/2680103002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:556:
return manager.mMediaNotificationInfo;
Feel free to ignore but my love for ternary operator requires me to say that you
can do:
`return (manager == null) ? null : manager.mMediaNotificationInfo;`

[Zhiqiang Zhang (Slow), 2017-02-08 16:01:38]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2017-02-08 16:01:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
mariakhomenko@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2680103002/#ps20001
(title: "nit")

[Zhiqiang Zhang (Slow), 2017-02-08 16:01:46]

https://codereview.chromium.org/2680103002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
(right):

https://codereview.chromium.org/2680103002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:556:
return manager.mMediaNotificationInfo;
On 2017/02/08 12:21:05, mlamouri wrote:
> Feel free to ignore but my love for ternary operator requires me to say that
you
> can do:
> `return (manager == null) ? null : manager.mMediaNotificationInfo;`

Done.

[commit-bot: I haz the power, 2017-02-08 16:02:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 17:56:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486569698824650,
"parent_rev": "40e953ebe96419099c00d6a31ee735497d1cc6b8", "commit_rev":
"e9c5df7d3be68ce0d8cf656dac0b9a1912ea5a28"}

[commit-bot: I haz the power, 2017-02-08 17:57:34]

Description was changed from

==========
[Media>UI] Reset media session actions when navigating away

There is a bug caused by media session actions being not properly reset
when navigating away, so that the notification control buttons stays the
same when the new page starts to play media. This CL fixes the issue.

BUG=689664
==========

to

==========
[Media>UI] Reset media session actions when navigating away

There is a bug caused by media session actions being not properly reset
when navigating away, so that the notification control buttons stays the
same when the new page starts to play media. This CL fixes the issue.

BUG=689664

Review-Url: https://codereview.chromium.org/2680103002
Cr-Commit-Position: refs/heads/master@{#449032}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9c5df7d3be68ce0d8cf656dac0b...
==========

[commit-bot: I haz the power, 2017-02-08 17:57:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e9c5df7d3be68ce0d8cf656dac0b...