Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2685883008: Revert of Move file_handlers API from //chrome to //extensions (Closed)

Created:
3 years, 10 months ago by Bret
Modified:
3 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, tfarina, yamaguchi+watch_chromium.org, oka+watch_chromium.org, nhiroki, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, Rahul Chaturvedi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move file_handlers API from //chrome to //extensions (patchset #5 id:80001 of https://codereview.chromium.org/2685453002/ ) Reason for revert: Broke compile on Linux x64. Example failure: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/16205 The build error is kind of confusing to me so apologizes in advance if this is the wrong CL. Original issue's description: > Move file_handlers API from //chrome to //extensions > > Largely mechanical CL via move_source_file.py, subbing some Profile usage > for BrowserContext. > > Results in removing some DEPS exceptions and #includes from //apps. > > BUG=679870 > > Review-Url: https://codereview.chromium.org/2685453002 > Cr-Commit-Position: refs/heads/master@{#449460} > Committed: https://chromium.googlesource.com/chromium/src/+/10d5e4e8430e41ca148452f2f8582db517846799 TBR=benwells@chromium.org,mtomasz@chromium.org,tzik@chromium.org,michaelpg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=679870 Review-Url: https://codereview.chromium.org/2685883008 Cr-Commit-Position: refs/heads/master@{#449465} Committed: https://chromium.googlesource.com/chromium/src/+/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1224 lines, -1222 lines) Patch
M apps/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M apps/launcher.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/open_util.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/fileapi/external_file_url_request_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +1 line, -1 line 0 comments Download
A chrome/browser/extensions/api/file_handlers/api_file_handler_util_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/file_handlers/app_file_handler_util.h View 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 1 chunk +361 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/file_handlers/directory_util.h View 1 chunk +55 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/file_handlers/directory_util.cc View 1 chunk +110 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/file_handlers/directory_util_unittest.cc View 1 chunk +69 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/file_handlers/mime_util.h View 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/file_handlers/mime_util.cc View 1 chunk +228 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc View 1 chunk +149 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/browser/api/file_handlers/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D extensions/browser/api/file_handlers/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/browser/api/file_handlers/app_file_handler_util.h View 1 chunk +0 lines, -82 lines 0 comments Download
D extensions/browser/api/file_handlers/app_file_handler_util.cc View 1 chunk +0 lines, -359 lines 0 comments Download
D extensions/browser/api/file_handlers/app_file_handler_util_unittest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D extensions/browser/api/file_handlers/directory_util.h View 1 chunk +0 lines, -57 lines 0 comments Download
D extensions/browser/api/file_handlers/directory_util.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D extensions/browser/api/file_handlers/directory_util_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D extensions/browser/api/file_handlers/mime_util.h View 1 chunk +0 lines, -80 lines 0 comments Download
D extensions/browser/api/file_handlers/mime_util.cc View 1 chunk +0 lines, -212 lines 0 comments Download
D extensions/browser/api/file_handlers/mime_util_unittest.cc View 1 chunk +0 lines, -146 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Bret
Created Revert of Move file_handlers API from //chrome to //extensions
3 years, 10 months ago (2017-02-09 23:41:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685883008/1
3 years, 10 months ago (2017-02-09 23:42:10 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 23:44:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9790279a2f9d6fb329b9fb6140f1...

Powered by Google App Engine
This is Rietveld 408576698