Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2685583004: Move Java style guide to source code repository. (Closed)

Created:
3 years, 10 months ago by nyquist
Modified:
3 years, 10 months ago
Reviewers:
Ted C, Yaron, jam, agrieve, gone
CC:
chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Java style guide to source code repository. Up until now, the Java style guide has been living on the Chromium wiki page at: https://sites.google.com/a/chromium.org/dev/developers/coding-style/java Recently, documentation regarding our code base has moved over to the code repository instead of being in the wiki, so this CL moves the Java style guide over, next to the C++ style guide. BUG=None Review-Url: https://codereview.chromium.org/2685583004 Cr-Commit-Position: refs/heads/master@{#449487} Committed: https://chromium.googlesource.com/chromium/src/+/9d61f9892ab9659a96a1cbcdde1ee53be44c2fac

Patch Set 1 : Initial port from wiki page to Markdown format #

Patch Set 2 : Make style more consistent and update URLs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -1 line) Patch
A styleguide/java/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
A styleguide/java/java.md View 1 1 chunk +71 lines, -0 lines 0 comments Download
M styleguide/styleguide.md View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (5 generated)
nyquist
Everyone, PTAL. This is the initial port of our wiki page documentation from https://sites.google.com/a/chromium.org/dev/developers/coding-style/java to ...
3 years, 10 months ago (2017-02-07 21:15:56 UTC) #2
Ted C
lgtm
3 years, 10 months ago (2017-02-08 00:32:39 UTC) #3
gone
lgtm
3 years, 10 months ago (2017-02-08 01:00:07 UTC) #4
Yaron
On 2017/02/08 01:00:07, dfalcantara (load balance plz) wrote: > lgtm lgtm
3 years, 10 months ago (2017-02-09 16:02:01 UTC) #5
agrieve
On 2017/02/09 16:02:01, Yaron (limited availability) wrote: > On 2017/02/08 01:00:07, dfalcantara (load balance plz) ...
3 years, 10 months ago (2017-02-09 23:46:33 UTC) #6
nyquist
Seems like we all approve of this starting point then :-)
3 years, 10 months ago (2017-02-09 23:47:31 UTC) #7
nyquist
jam: PTAL as top-level OWNERS Note: Follow-up patch is in https://codereview.chromium.org/2681923003 which depending on the ...
3 years, 10 months ago (2017-02-09 23:51:39 UTC) #9
jam
lgtm
3 years, 10 months ago (2017-02-09 23:54:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685583004/20001
3 years, 10 months ago (2017-02-09 23:55:22 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 00:29:59 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d61f9892ab9659a96a1cbcdde1e...

Powered by Google App Engine
This is Rietveld 408576698