Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2681923003: Organize Java style guide and add a more sections (Closed)

Created:
3 years, 10 months ago by nyquist
Modified:
3 years, 10 months ago
Reviewers:
Ted C, gone, agrieve
CC:
chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Organize Java style guide and add a more sections New sections: - Clang-formatting - Mailing list - Tools (IDEs, checkstyle, lint) - File Headers - TODOs - Curly braces - Exceptions - Miscellany BUG=None Review-Url: https://codereview.chromium.org/2681923003 Cr-Commit-Position: refs/heads/master@{#450790} Committed: https://chromium.googlesource.com/chromium/src/+/aae4c7cdac8ce3bae51257e05de6bba8e7492c98

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase for good measure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -29 lines) Patch
M styleguide/java/java.md View 2 chunks +112 lines, -29 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
nyquist
dfalcantara, agrieve: PTAL Location-section is unchanged and just moved lower down on the page. I ...
3 years, 10 months ago (2017-02-07 23:32:57 UTC) #2
nyquist
tedchoc: PTAL (also see previous published message)
3 years, 10 months ago (2017-02-08 00:14:44 UTC) #4
nyquist
This is how it looks like after patch set 1: https://chromium.googlesource.com/chromium/src.git/+/7a737957d207455faff0e4d7371b66ee9427d091/styleguide/java/java.md
3 years, 10 months ago (2017-02-08 00:16:54 UTC) #5
nyquist
https://codereview.chromium.org/2681923003/diff/1/styleguide/java/java.md File styleguide/java/java.md (right): https://codereview.chromium.org/2681923003/diff/1/styleguide/java/java.md#newcode127 styleguide/java/java.md:127: ## Location Location-section is unedited, but moved lower down, ...
3 years, 10 months ago (2017-02-08 06:02:31 UTC) #6
gone
lgtm
3 years, 10 months ago (2017-02-09 23:27:41 UTC) #7
agrieve
On 2017/02/09 23:27:41, dfalcantara (load balance plz) wrote: > lgtm lgtm
3 years, 10 months ago (2017-02-09 23:44:36 UTC) #8
Ted C
lgtm
3 years, 10 months ago (2017-02-15 05:07:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681923003/20001
3 years, 10 months ago (2017-02-15 19:20:09 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 20:42:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aae4c7cdac8ce3bae51257e05de6...

Powered by Google App Engine
This is Rietveld 408576698