Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2685563002: Remove trace() methods for stack-only classes. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, blink-reviews-bindings_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove trace() methods for stack-only classes. A class annotated with STACK_ALLOCATED() does not require a trace method, as its heap references are reachable and kept alive by virtue of being on the stack, should any conservative GC go ahead. R=haraken BUG= Review-Url: https://codereview.chromium.org/2685563002 Cr-Commit-Position: refs/heads/master@{#448627} Committed: https://chromium.googlesource.com/chromium/src/+/aa64c8d55556dcbfb21a5b5a3f3775adb55cd823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionModifier.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionModifier.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
sof
please take a look.
3 years, 10 months ago (2017-02-07 13:29:26 UTC) #5
haraken
LGTM
3 years, 10 months ago (2017-02-07 15:12:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685563002/1
3 years, 10 months ago (2017-02-07 15:46:52 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 15:52:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa64c8d55556dcbfb21a5b5a3f37...

Powered by Google App Engine
This is Rietveld 408576698