Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: third_party/WebKit/Source/core/editing/SelectionModifier.h

Issue 2685563002: Remove trace() methods for stack-only classes. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 LayoutUnit xPosForVerticalArrowNavigation() const { 50 LayoutUnit xPosForVerticalArrowNavigation() const {
51 return m_xPosForVerticalArrowNavigation; 51 return m_xPosForVerticalArrowNavigation;
52 } 52 }
53 const VisibleSelection& selection() const { return m_selection; } 53 const VisibleSelection& selection() const { return m_selection; }
54 54
55 bool modify(EAlteration, SelectionDirection, TextGranularity); 55 bool modify(EAlteration, SelectionDirection, TextGranularity);
56 bool modifyWithPageGranularity(EAlteration, 56 bool modifyWithPageGranularity(EAlteration,
57 unsigned verticalDistance, 57 unsigned verticalDistance,
58 VerticalDirection); 58 VerticalDirection);
59 59
60 DECLARE_VIRTUAL_TRACE();
61
62 private: 60 private:
63 // TODO(yosin): We should move |EPositionType| to "SelectionModifier.cpp", 61 // TODO(yosin): We should move |EPositionType| to "SelectionModifier.cpp",
64 // it is only used for implementing |modify()|. 62 // it is only used for implementing |modify()|.
65 // TODO(yosin) We should use capitalized name for |EPositionType|. 63 // TODO(yosin) We should use capitalized name for |EPositionType|.
66 enum EPositionType { START, END, BASE, EXTENT }; // NOLINT 64 enum EPositionType { START, END, BASE, EXTENT }; // NOLINT
67 65
68 LocalFrame* frame() const { return m_frame; } 66 LocalFrame* frame() const { return m_frame; }
69 67
70 TextDirection directionOfEnclosingBlock() const; 68 TextDirection directionOfEnclosingBlock() const;
71 TextDirection directionOfSelection() const; 69 TextDirection directionOfSelection() const;
(...skipping 17 matching lines...) Expand all
89 LayoutUnit m_xPosForVerticalArrowNavigation; 87 LayoutUnit m_xPosForVerticalArrowNavigation;
90 88
91 DISALLOW_COPY_AND_ASSIGN(SelectionModifier); 89 DISALLOW_COPY_AND_ASSIGN(SelectionModifier);
92 }; 90 };
93 91
94 LayoutUnit NoXPosForVerticalArrowNavigation(); 92 LayoutUnit NoXPosForVerticalArrowNavigation();
95 93
96 } // namespace blink 94 } // namespace blink
97 95
98 #endif // SelectionModifier_h 96 #endif // SelectionModifier_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698