Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2685533003: Revert of Do not block in SimpleThread::Start(). (Closed)

Created:
3 years, 10 months ago by battre
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vmpstr+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not block in SimpleThread::Start(). (patchset #6 id:100001 of https://codereview.chromium.org/2664953004/ ) Reason for revert: Attempt to fix iOS Simulator issues with SkipOnShutdown/TaskSchedulerTaskTrackerTest.WillPostAndRunLongTaskBeforeShutdown/0 Original issue's description: > Do not block in SimpleThread::Start(). > > There is no good reason to block in SimpleThread::Start(). > In addition to introducing unnecessary latency, blocking in > Start() prevents a non-joinable DelegateSimpleThread from > being deleted from Run() without external synchronization > (it is wrong to delete SimpleThread while Start() is waiting > on the |event_| member). > > BUG= > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2664953004 > Cr-Commit-Position: refs/heads/master@{#448622} > Committed: https://chromium.googlesource.com/chromium/src/+/8ad2f4f9bb3d55974ea1707ff4186bbe321ea499 TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2685533003 Cr-Commit-Position: refs/heads/master@{#448658} Committed: https://chromium.googlesource.com/chromium/src/+/40937c0272cf7ae2342b318cf394dbdaddaa5a76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -65 lines) Patch
M base/threading/sequenced_worker_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/simple_thread.h View 4 chunks +15 lines, -19 lines 0 comments Download
M base/threading/simple_thread.cc View 2 chunks +16 lines, -28 lines 0 comments Download
M base/threading/simple_thread_unittest.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M base/threading/thread_restrictions.h View 2 chunks +2 lines, -0 lines 0 comments Download
M base/win/wait_chain_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/categorized_worker_pool.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/categorized_worker_pool.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
battre
Created Revert of Do not block in SimpleThread::Start().
3 years, 10 months ago (2017-02-07 17:39:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685533003/1
3 years, 10 months ago (2017-02-07 17:40:11 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 17:41:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40937c0272cf7ae2342b318cf394...

Powered by Google App Engine
This is Rietveld 408576698