DescriptionRevert of Do not block in SimpleThread::Start(). (patchset #6 id:100001 of https://codereview.chromium.org/2664953004/ )
Reason for revert:
Attempt to fix iOS Simulator issues with SkipOnShutdown/TaskSchedulerTaskTrackerTest.WillPostAndRunLongTaskBeforeShutdown/0
Original issue's description:
> Do not block in SimpleThread::Start().
>
> There is no good reason to block in SimpleThread::Start().
> In addition to introducing unnecessary latency, blocking in
> Start() prevents a non-joinable DelegateSimpleThread from
> being deleted from Run() without external synchronization
> (it is wrong to delete SimpleThread while Start() is waiting
> on the |event_| member).
>
> BUG=
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2664953004
> Cr-Commit-Position: refs/heads/master@{#448622}
> Committed: https://chromium.googlesource.com/chromium/src/+/8ad2f4f9bb3d55974ea1707ff4186bbe321ea499
TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2685533003
Cr-Commit-Position: refs/heads/master@{#448658}
Committed: https://chromium.googlesource.com/chromium/src/+/40937c0272cf7ae2342b318cf394dbdaddaa5a76
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|