Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2685373002: [Media>Session] Pause all players for non-routed frames when receiving PAUSE action (Closed)

Created:
3 years, 10 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Media>Session] Pause all players for non-routed frames when receiving PAUSE action Previously, when a page uses MediaSession API, the PAUSE action is only sent to the frame that is routed, other frames may be still playing media, causing the session to be still active. In this CL, apart from sending the PAUSE action to the frame, we pause the players in all non-routed frames. BUG=685978 Review-Url: https://codereview.chromium.org/2660263002 Cr-Commit-Position: refs/heads/master@{#449622} (cherry picked from commit ded5aed116f603b4d7e4e5b83abeb25e7f802198) Review-Url: https://codereview.chromium.org/2685373002 . Cr-Commit-Position: refs/branch-heads/2987@{#437} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9a550d13567114af60c8f287393c3bec87c3d79c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -4 lines) Patch
M content/browser/media/session/media_session_impl.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M content/browser/media/session/media_session_impl_service_routing_unittest.cc View 9 chunks +87 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 10 months ago (2017-02-10 16:07:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a550d13567114af60c8f287393c3bec87c3d79c.

Powered by Google App Engine
This is Rietveld 408576698