[Media>Session] Pause all players for non-routed frames when receiving PAUSE action

[Media>Session] Pause all players for non-routed frames when receiving PAUSE action

Previously, when a page uses MediaSession API, the PAUSE action is only
sent to the frame that is routed, other frames may be still playing
media, causing the session to be still active. In this CL, apart from
sending the PAUSE action to the frame, we pause the players in all
non-routed frames.

BUG=685978
Review-Url: https://codereview.chromium.org/2660263002
Cr-Commit-Position: refs/heads/master@{#449622}
Committed: https://chromium.googlesource.com/chromium/src/+/ded5aed116f603b4d7e4e5b83abeb25e7f802198

[Zhiqiang Zhang (Slow), 2017-02-08 15:58:22]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2017-02-08 15:58:22]

PTAL

[mlamouri (slow - plz ping), 2017-02-10 14:17:43]

lgtm \o/

https://codereview.chromium.org/2660263002/diff/20001/content/browser/media/s...
File content/browser/media/session/media_session_impl.cc (right):

https://codereview.chromium.org/2660263002/diff/20001/content/browser/media/s...
content/browser/media/session/media_session_impl.cc:635: if
(player.observer->GetRenderFrameHost() != rfh_of_routed_service)
styte: you need { } because the statement is in two lines (wrapping)

[Zhiqiang Zhang (Slow), 2017-02-10 14:24:52]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2017-02-10 14:24:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2660263002/#ps40001
(title: "nit and style")

[commit-bot: I haz the power, 2017-02-10 14:25:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhiqiang Zhang (Slow), 2017-02-10 14:25:58]

https://codereview.chromium.org/2660263002/diff/20001/content/browser/media/s...
File content/browser/media/session/media_session_impl.cc (right):

https://codereview.chromium.org/2660263002/diff/20001/content/browser/media/s...
content/browser/media/session/media_session_impl.cc:635: if
(player.observer->GetRenderFrameHost() != rfh_of_routed_service)
On 2017/02/10 14:17:43, mlamouri wrote:
> styte: you need { } because the statement is in two lines (wrapping)

Done.

[commit-bot: I haz the power, 2017-02-10 15:20:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486736692181220,
"parent_rev": "cf9ceffb349c7393139625fc5913df52d1a57814", "commit_rev":
"ded5aed116f603b4d7e4e5b83abeb25e7f802198"}

[commit-bot: I haz the power, 2017-02-10 15:21:17]

Description was changed from

==========
[Media>Session] Pause all players for non-routed frames when receiving PAUSE
action

Previously, when a page uses MediaSession API, the PAUSE action is only
sent to the frame that is routed, other frames may be still playing
media, causing the session to be still active. In this CL, apart from
sending the PAUSE action to the frame, we pause the players in all
non-routed frames.

BUG=685978
==========

to

==========
[Media>Session] Pause all players for non-routed frames when receiving PAUSE
action

Previously, when a page uses MediaSession API, the PAUSE action is only
sent to the frame that is routed, other frames may be still playing
media, causing the session to be still active. In this CL, apart from
sending the PAUSE action to the frame, we pause the players in all
non-routed frames.

BUG=685978

Review-Url: https://codereview.chromium.org/2660263002
Cr-Commit-Position: refs/heads/master@{#449622}
Committed:
https://chromium.googlesource.com/chromium/src/+/ded5aed116f603b4d7e4e5b83abe...
==========

[commit-bot: I haz the power, 2017-02-10 15:21:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ded5aed116f603b4d7e4e5b83abe...