Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2685343002: Update the shippingType option to not allow invalid strings. (Closed)

Created:
3 years, 10 months ago by Hwanseung Lee
Modified:
3 years, 10 months ago
CC:
chromium-reviews, haraken, blink-reviews, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, Hwanseung Lee(hs1217.lee), Rick Byers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : layout test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/payments/payment-request-interface.html View 1 2 chunks +15 lines, -25 lines 1 comment Download
M third_party/WebKit/Source/modules/payments/PaymentOptions.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (14 generated)
Hwanseung Lee
@rouslan, zino PTAL, thank you.
3 years, 10 months ago (2017-02-13 14:49:44 UTC) #11
zino
lgtm
3 years, 10 months ago (2017-02-13 15:15:06 UTC) #12
please use gerrit instead
Since this will change the interface, please send out an intent to implement and ship ...
3 years, 10 months ago (2017-02-13 15:36:14 UTC) #13
zino
On 2017/02/13 15:36:14, rouslan wrote: > Since this will change the interface, please send out ...
3 years, 10 months ago (2017-02-13 22:28:52 UTC) #14
zino
To clarify this, I'll add foolip@ as API owner. :) Thank you.
3 years, 10 months ago (2017-02-13 22:31:14 UTC) #16
zino
On 2017/02/13 22:31:14, zino wrote: > To clarify this, I'll add foolip@ as API owner. ...
3 years, 10 months ago (2017-02-13 23:15:14 UTC) #17
foolip
In PaymentRequest.cpp, can you also add a DCHECK in the final else branch, to show ...
3 years, 10 months ago (2017-02-14 13:32:05 UTC) #18
foolip
In PaymentRequest.cpp, can you also add a DCHECK in the final else branch, to show ...
3 years, 10 months ago (2017-02-14 13:32:05 UTC) #19
foolip
On 2017/02/13 23:15:14, zino wrote: > On 2017/02/13 22:31:14, zino wrote: > > To clarify ...
3 years, 10 months ago (2017-02-14 13:34:56 UTC) #20
foolip
On 2017/02/14 13:34:56, foolip wrote: > On 2017/02/13 23:15:14, zino wrote: > > On 2017/02/13 ...
3 years, 10 months ago (2017-02-14 13:35:16 UTC) #21
please use gerrit instead
lgtm
3 years, 10 months ago (2017-02-14 14:57:20 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685343002/20001
3 years, 10 months ago (2017-02-14 15:03:16 UTC) #24
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 16:35:55 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6396f2506e7fa1793a7223f2a1a1...

Powered by Google App Engine
This is Rietveld 408576698