third_party/WebKit/Source/modules/payments/PaymentOptions.idl - Issue 2685343002: Update the shippingType option to not allow invalid strings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentOptions.idl

Issue 2685343002: Update the shippingType option to not allow invalid strings. (Closed)

Patch Set: layout test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/browser-payment-api/#paymentoptions-dictionary	5 // https://w3c.github.io/browser-payment-api/#paymentoptions-dictionary

6	6

7 enum PaymentShippingType {	7 enum PaymentShippingType {

8 "shipping",	8 "shipping",

9 "delivery",	9 "delivery",

10 "pickup"	10 "pickup"

11 };	11 };

12	12

13 dictionary PaymentOptions {	13 dictionary PaymentOptions {

14 [RuntimeEnabled=PaymentRequestPayerName] boolean requestPayerName = false;	14 [RuntimeEnabled=PaymentRequestPayerName] boolean requestPayerName = false;

15 boolean requestPayerEmail = false;	15 boolean requestPayerEmail = false;

16 boolean requestPayerPhone = false;	16 boolean requestPayerPhone = false;

17 boolean requestShipping = false;	17 boolean requestShipping = false;

18 DOMString shippingType = "shipping";	18 PaymentShippingType shippingType = "shipping";

19 };	19 };

OLD	NEW