Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2685293003: [parsing] Fix maybe-assigned for top-level class declarations. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parsing] Fix maybe-assigned for top-level class declarations. Move the logic into Scope::DeclareVariable to be more robust. BUG=v8:5636 Review-Url: https://codereview.chromium.org/2685293003 Cr-Commit-Position: refs/heads/master@{#43098} Committed: https://chromium.googlesource.com/v8/v8/+/a450d3aea2560011613d88c49a2b9693005933ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M src/ast/scopes.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +15 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
neis
ptal
3 years, 10 months ago (2017-02-10 12:44:03 UTC) #7
marja
lgtm
3 years, 10 months ago (2017-02-10 13:17:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685293003/1
3 years, 10 months ago (2017-02-10 13:23:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/a450d3aea2560011613d88c49a2b9693005933ad
3 years, 10 months ago (2017-02-10 13:24:56 UTC) #13
adamk
3 years, 10 months ago (2017-02-10 19:59:14 UTC) #14
Message was sent while issue was closed.
lgtm, I like this code organization better in addition to getting more
correctness

Powered by Google App Engine
This is Rietveld 408576698