Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2684343004:
[test] Add some more tests for top-level maybe-assigned. (Closed)
Description[test] Add some more tests for top-level maybe-assigned.
Also make them use the helpers that I introduced recently.
BUG=v8:5636
Review-Url: https://codereview.chromium.org/2684343004
Cr-Commit-Position: refs/heads/master@{#43100}
Committed: https://chromium.googlesource.com/v8/v8/+/6d1c114c721f319dc19fedd817c536f55d5a9eef
Patch Set 1 #Patch Set 2 : Fix initializer. #Patch Set 3 : Again. #
Depends on Patchset: Messages
Total messages: 21 (17 generated)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [test] Add some more tests for top-level maybe-assigned. BUG= ========== to ========== [test] Add some more tests for top-level maybe-assigned. Also make them use the helpers that I introduced recently. BUG=v8:5636 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
neis@chromium.org changed reviewers: + marja@chromium.org
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by neis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486734413556580,
"parent_rev": "331d4852b4b1fd5d759c738612a4c6283e9950d3", "commit_rev":
"6d1c114c721f319dc19fedd817c536f55d5a9eef"}
Message was sent while issue was closed.
Description was changed from ========== [test] Add some more tests for top-level maybe-assigned. Also make them use the helpers that I introduced recently. BUG=v8:5636 ========== to ========== [test] Add some more tests for top-level maybe-assigned. Also make them use the helpers that I introduced recently. BUG=v8:5636 Review-Url: https://codereview.chromium.org/2684343004 Cr-Commit-Position: refs/heads/master@{#43100} Committed: https://chromium.googlesource.com/v8/v8/+/6d1c114c721f319dc19fedd817c536f55d5... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/6d1c114c721f319dc19fedd817c536f55d5... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
