Fix ReadRemoteData in ModuleEventSinkImpl

Fix ReadRemoteData in ModuleEventSinkImpl

The address of the pointer to the buffer was passed to ReadProcessMemory
instead of the address of the buffer.

Review-Url: https://codereview.chromium.org/2685213002
Cr-Commit-Position: refs/heads/master@{#449463}
Committed: https://chromium.googlesource.com/chromium/src/+/a4393e6d033d3f47d70163c11120ecec68d4393e

[Patrick Monette, 2017-02-09 22:30:31]

pmonette@chromium.org changed reviewers:
+ chrisha@chromium.org

[Patrick Monette, 2017-02-09 22:30:32]

PTAL

[chrisha, 2017-02-09 22:34:15]

lgtm!

[Patrick Monette, 2017-02-09 22:34:34]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2017-02-09 22:35:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 23:27:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486679674419010, "parent_rev":
"f5f830019d57e4405d74568dde8989b5cc7661c4", "commit_rev":
"a4393e6d033d3f47d70163c11120ecec68d4393e"}

[commit-bot: I haz the power, 2017-02-09 23:28:10]

Description was changed from

==========
Fix ReadRemoteData in ModuleEventSinkImpl

The address of the pointer to the buffer was passed to ReadProcessMemory
instead of the address of the buffer.
==========

to

==========
Fix ReadRemoteData in ModuleEventSinkImpl

The address of the pointer to the buffer was passed to ReadProcessMemory
instead of the address of the buffer.

Review-Url: https://codereview.chromium.org/2685213002
Cr-Commit-Position: refs/heads/master@{#449463}
Committed:
https://chromium.googlesource.com/chromium/src/+/a4393e6d033d3f47d70163c11120...
==========

[commit-bot: I haz the power, 2017-02-09 23:28:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4393e6d033d3f47d70163c11120...

[Nico, 2017-02-15 15:35:08]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-02-15 15:35:09]

https://codereview.chromium.org/2685213002/diff/1/chrome/browser/conflicts/mo...
File chrome/browser/conflicts/module_event_sink_impl_win.cc (right):

https://codereview.chromium.org/2685213002/diff/1/chrome/browser/conflicts/mo...
chrome/browser/conflicts/module_event_sink_impl_win.cc:67: if
(!::ReadProcessMemory(process, typed_address, data, sizeof(data),
This still looks a bit funny. sizeof(data) will always be size of a pointer.
While &data was passed in, that was consistent, but now that you pass data do
you want sizeof(T) here?

[Nico, 2017-02-15 16:07:14]

On 2017/02/15 15:35:09, Nico wrote:
>
https://codereview.chromium.org/2685213002/diff/1/chrome/browser/conflicts/mo...
> File chrome/browser/conflicts/module_event_sink_impl_win.cc (right):
> 
>
https://codereview.chromium.org/2685213002/diff/1/chrome/browser/conflicts/mo...
> chrome/browser/conflicts/module_event_sink_impl_win.cc:67: if
> (!::ReadProcessMemory(process, typed_address, data, sizeof(data),
> This still looks a bit funny. sizeof(data) will always be size of a pointer.
> While &data was passed in, that was consistent, but now that you pass data do
> you want sizeof(T) here?

After looking at this some more, I think that's correct. Fix:
https://codereview.chromium.org/2691373003/