Fix ReadRemoteData in ModuleEventSinkImpl

chrome/browser/conflicts/module_event_sink_impl_win.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/conflicts/module_event_sink_impl_win.h"
 
 #include <windows.h>
 #include <psapi.h>
 
 #include <utility>
@@ skipping 46 matching lines @@
   return true;
 }
 
 // Reads the typed data from a remote process. Returns true on success, false
 // otherwise.
 template <typename T>
 bool ReadRemoteData(base::ProcessHandle process, uint64_t address, T* data) {
   const void* typed_address =
       reinterpret_cast<const void*>(static_cast<uintptr_t>(address));
   SIZE_T bytes_read = 0;
-  if (!::ReadProcessMemory(process, typed_address, &data, sizeof(data),
+  if (!::ReadProcessMemory(process, typed_address, data, sizeof(data),

[Nico, 2017/02/15 15:35:09]

This still looks a bit funny. sizeof(data) will always be size of a pointer.
While &data was passed in, that was consistent, but now that you pass data do
you want sizeof(T) here?

                            &bytes_read)) {
     return false;
   }
   if (bytes_read != sizeof(data))
     return false;
   return true;
 }
 
 // Reads the time date stamp from the module loaded in the provided remote
 // |process| at the provided remote |load_address|.
@@ skipping 124 matching lines @@
   module_database_->OnModuleLoad(process_id_, creation_time_, module_path,
                                  module_size, module_time_date_stamp,
                                  load_address);
 }
 
 void ModuleEventSinkImpl::OnModuleUnload(uint64_t load_address) {
   // Forward this directly to the module database.
   module_database_->OnModuleUnload(process_id_, creation_time_,
                                    static_cast<uintptr_t>(load_address));
 }