Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2685033002:
android: Default symbol_level to 1 in 32-bit builds for clang too (Closed)
Descriptionandroid: Default symbol_level to 1 in 32-bit builds for clang too
clang finally hit the same file size wall that gcc hit a while ago.
(Locally, building lib_android_webview_unittests__library.so goes
from 6.5min to 3.8min on my linux box and file size of the .so goes
from over 4.1GB to 320MB -- at the cost of no detailed debug info
of coarse. Feels like investigating fission or similar would probably
be beneficial for the android build.)
BUG=648948, 685259
Review-Url: https://codereview.chromium.org/2685033002
Cr-Commit-Position: refs/heads/master@{#449314}
Committed: https://chromium.googlesource.com/chromium/src/+/7be003ae95486a55fc2a9ef5fb34e26f702fc241
Patch Set 1 #
Total comments: 1
Messages
Total messages: 23 (15 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== android: Default symbol_level to 1 in 32-bit builds for clang too clang finally hit the same file size wall that gcc hit a while ago. BUG=648948,685259 ========== to ========== android: Default symbol_level to 1 in 32-bit builds for clang too clang finally hit the same file size wall that gcc hit a while ago. (Locally, building lib_android_webview_unittests__library.so goes from 6.5min to 3.8min on my linux box and file size of the .so goes from over 4.1GB to 320MB -- at the cost of no detailed debug info of coarse. Feels like investigating fission or similar would probably be beneficial for the android build.) BUG=648948,685259 ==========
thakis@chromium.org changed reviewers: + rnk@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
torne@chromium.org changed reviewers: + torne@chromium.org
https://codereview.chromium.org/2685033002/diff/1/build/config/compiler/compi... File build/config/compiler/compiler.gni (right): https://codereview.chromium.org/2685033002/diff/1/build/config/compiler/compi... build/config/compiler/compiler.gni:120: "Android 32-bit non-component, non-clang builds cannot have " + Should probably update the assert message to no longer say "non-clang".
The CQ bit was checked by thakis@chromium.org
On 2017/02/09 13:58:40, Torne wrote: > https://codereview.chromium.org/2685033002/diff/1/build/config/compiler/compi... > File build/config/compiler/compiler.gni (right): > > https://codereview.chromium.org/2685033002/diff/1/build/config/compiler/compi... > build/config/compiler/compiler.gni:120: "Android 32-bit non-component, non-clang > builds cannot have " + > Should probably update the assert message to no longer say "non-clang". Good point, will do, thanks.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486656082824170, "parent_rev":
"3f811f2f382ccdc9b5375c14cb8761c0a0257575", "commit_rev":
"7be003ae95486a55fc2a9ef5fb34e26f702fc241"}
Message was sent while issue was closed.
Description was changed from ========== android: Default symbol_level to 1 in 32-bit builds for clang too clang finally hit the same file size wall that gcc hit a while ago. (Locally, building lib_android_webview_unittests__library.so goes from 6.5min to 3.8min on my linux box and file size of the .so goes from over 4.1GB to 320MB -- at the cost of no detailed debug info of coarse. Feels like investigating fission or similar would probably be beneficial for the android build.) BUG=648948,685259 ========== to ========== android: Default symbol_level to 1 in 32-bit builds for clang too clang finally hit the same file size wall that gcc hit a while ago. (Locally, building lib_android_webview_unittests__library.so goes from 6.5min to 3.8min on my linux box and file size of the .so goes from over 4.1GB to 320MB -- at the cost of no detailed debug info of coarse. Feels like investigating fission or similar would probably be beneficial for the android build.) BUG=648948,685259 Review-Url: https://codereview.chromium.org/2685033002 Cr-Commit-Position: refs/heads/master@{#449314} Committed: https://chromium.googlesource.com/chromium/src/+/7be003ae95486a55fc2a9ef5fb34... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7be003ae95486a55fc2a9ef5fb34... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
