Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2015 The Chromium Authors. All rights reserved. | 1 # Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 import("//build/config/android/config.gni") | 5 import("//build/config/android/config.gni") |
| 6 import("//build/config/chrome_build.gni") | 6 import("//build/config/chrome_build.gni") |
| 7 import("//build/config/chromecast_build.gni") | 7 import("//build/config/chromecast_build.gni") |
| 8 import("//build/config/compiler/pgo/pgo.gni") | 8 import("//build/config/compiler/pgo/pgo.gni") |
| 9 import("//build/config/sanitizers/sanitizers.gni") | 9 import("//build/config/sanitizers/sanitizers.gni") |
| 10 import("//build/toolchain/goma.gni") | 10 import("//build/toolchain/goma.gni") |
| (...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 80 current_cpu == "arm" || current_cpu == "arm64"))) | 80 current_cpu == "arm" || current_cpu == "arm64"))) |
| 81 } | 81 } |
| 82 | 82 |
| 83 # If it wasn't manually set, set to an appropriate default. | 83 # If it wasn't manually set, set to an appropriate default. |
| 84 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level") | 84 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level") |
| 85 if (symbol_level == -1) { | 85 if (symbol_level == -1) { |
| 86 if (is_android && use_order_profiling) { | 86 if (is_android && use_order_profiling) { |
| 87 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which | 87 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which |
| 88 # causes the linker to produce an invalid ELF. http://crbug.com/574476 | 88 # causes the linker to produce an invalid ELF. http://crbug.com/574476 |
| 89 symbol_level = 0 | 89 symbol_level = 0 |
| 90 } else if (is_android && !is_component_build && !is_clang && | 90 } else if (is_android && !is_component_build && |
| 91 !(android_64bit_target_cpu && !build_apk_secondary_abi)) { | 91 !(android_64bit_target_cpu && !build_apk_secondary_abi)) { |
| 92 # Reduce symbol level when it will cause invalid elf files to be created | 92 # Reduce symbol level when it will cause invalid elf files to be created |
| 93 # (due to file size). https://crbug.com/648948. | 93 # (due to file size). https://crbug.com/648948. |
| 94 symbol_level = 1 | 94 symbol_level = 1 |
| 95 } else if (is_win && use_goma && !is_clang) { | 95 } else if (is_win && use_goma && !is_clang) { |
| 96 # goma doesn't support PDB files, so we disable symbols during goma | 96 # goma doesn't support PDB files, so we disable symbols during goma |
| 97 # compilation because otherwise the redundant debug information generated | 97 # compilation because otherwise the redundant debug information generated |
| 98 # by visual studio (repeated in every .obj file) makes linker | 98 # by visual studio (repeated in every .obj file) makes linker |
| 99 # memory consumption and link times unsustainable (crbug.com/630074). | 99 # memory consumption and link times unsustainable (crbug.com/630074). |
| 100 # Clang on windows does not have this issue. | 100 # Clang on windows does not have this issue. |
| 101 symbol_level = 1 | 101 symbol_level = 1 |
| 102 } else if ((!is_nacl && !is_linux) || is_debug || is_official_build || | 102 } else if ((!is_nacl && !is_linux) || is_debug || is_official_build || |
| 103 is_chromecast) { | 103 is_chromecast) { |
| 104 # Linux is slowed by having symbols as part of the target binary, whereas | 104 # Linux is slowed by having symbols as part of the target binary, whereas |
| 105 # Mac and Windows have them separate, so in Release Linux, default them off, | 105 # Mac and Windows have them separate, so in Release Linux, default them off, |
| 106 # but keep them on for Official builds and Chromecast builds. | 106 # but keep them on for Official builds and Chromecast builds. |
| 107 symbol_level = 2 | 107 symbol_level = 2 |
| 108 } else if (using_sanitizer) { | 108 } else if (using_sanitizer) { |
| 109 # Sanitizers require symbols for filename suppressions to work. | 109 # Sanitizers require symbols for filename suppressions to work. |
| 110 symbol_level = 1 | 110 symbol_level = 1 |
| 111 } else { | 111 } else { |
| 112 symbol_level = 0 | 112 symbol_level = 0 |
| 113 } | 113 } |
| 114 } | 114 } |
| 115 | 115 |
| 116 # Assert that the configuration isn't going to hit https://crbug.com/648948. | 116 # Assert that the configuration isn't going to hit https://crbug.com/648948. |
| 117 assert(ignore_elf32_limitations || !is_android || | 117 assert(ignore_elf32_limitations || !is_android || |
| 118 (android_64bit_target_cpu && !build_apk_secondary_abi) || | 118 (android_64bit_target_cpu && !build_apk_secondary_abi) || |
| 119 is_component_build || symbol_level < 2 || is_clang, | 119 is_component_build || symbol_level < 2, |
| 120 "Android 32-bit non-component, non-clang builds cannot have " + | 120 "Android 32-bit non-component, non-clang builds cannot have " + |
|
Torne
2017/02/09 13:58:40
Should probably update the assert message to no lo
| |
| 121 "symbol_level=2 due to 4GiB file size limit, see " + | 121 "symbol_level=2 due to 4GiB file size limit, see " + |
| 122 "https://crbug.com/648948. If you really want to try this out, " + | 122 "https://crbug.com/648948. If you really want to try this out, " + |
| 123 "set ignore_elf32_limitations=true.") | 123 "set ignore_elf32_limitations=true.") |
| OLD | NEW |