Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2684993003: Remove TextTrack.{add,remove}Region (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
foolip
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TextTrack.{add,remove}Region Removed from the spec by https://github.com/w3c/webvtt/pull/31 BUG=690014 Review-Url: https://codereview.chromium.org/2684993003 Cr-Commit-Position: refs/heads/master@{#449140} Committed: https://chromium.googlesource.com/chromium/src/+/54cf4b70b9b91b67258d0909188772c43c11c09f

Patch Set 1 #

Patch Set 2 : Update webexposed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -121 lines) Patch
D third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-list.html View 1 chunk +0 lines, -63 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/LoadableTextTrack.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
fs
3 years, 10 months ago (2017-02-08 16:27:03 UTC) #4
foolip
lgtm Bypassing all process since this hasn't shipped yet.
3 years, 10 months ago (2017-02-08 23:30:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684993003/20001
3 years, 10 months ago (2017-02-08 23:31:42 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 23:43:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54cf4b70b9b91b67258d09091887...

Powered by Google App Engine
This is Rietveld 408576698