Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrack.cpp

Issue 2684993003: Remove TextTrack.{add,remove}Region (Closed)
Patch Set: Update webexposed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/TextTrack.cpp
diff --git a/third_party/WebKit/Source/core/html/track/TextTrack.cpp b/third_party/WebKit/Source/core/html/track/TextTrack.cpp
index ec558c2f920a3aa89bf58153e86243ccca2c89a1..53ea365e8ebb0a352b44da6e069f42127e167ec2 100644
--- a/third_party/WebKit/Source/core/html/track/TextTrack.cpp
+++ b/third_party/WebKit/Source/core/html/track/TextTrack.cpp
@@ -301,57 +301,6 @@ VTTRegionList* TextTrack::regions() {
return nullptr;
}
-void TextTrack::addRegion(VTTRegion* region) {
- if (!region)
- return;
-
- VTTRegionList* regionList = ensureVTTRegionList();
-
- // 1. If the given region is in a text track list of regions, then remove
- // region from that text track list of regions.
- TextTrack* regionTrack = region->track();
- if (regionTrack && regionTrack != this)
- regionTrack->removeRegion(region, ASSERT_NO_EXCEPTION);
-
- // 2. If the method's TextTrack object's text track list of regions contains
- // a region with the same identifier as region replace the values of that
- // region's width, height, anchor point, viewport anchor point and scroll
- // attributes with those of region.
- VTTRegion* existingRegion = regionList->getRegionById(region->id());
- if (existingRegion) {
- existingRegion->updateParametersFromRegion(region);
- return;
- }
-
- // Otherwise: add region to the method's TextTrack object's text track
- // list of regions.
- region->setTrack(this);
- regionList->add(region);
-}
-
-void TextTrack::removeRegion(VTTRegion* region,
- ExceptionState& exceptionState) {
- if (!region)
- return;
-
- // 1. If the given region is not currently listed in the method's TextTrack
- // object's text track list of regions, then throw a NotFoundError exception.
- if (region->track() != this) {
- exceptionState.throwDOMException(NotFoundError,
- "The specified region is not listed in "
- "the TextTrack's list of regions.");
- return;
- }
-
- if (!m_regions || !m_regions->remove(region)) {
- exceptionState.throwDOMException(InvalidStateError,
- "Failed to remove the specified region.");
- return;
- }
-
- region->setTrack(0);
-}
-
void TextTrack::cueWillChange(TextTrackCue* cue) {
// The cue may need to be repositioned in the media element's interval tree,
// may need to be re-rendered, etc, so remove it before the modification...
« no previous file with comments | « third_party/WebKit/Source/core/html/track/TextTrack.h ('k') | third_party/WebKit/Source/core/html/track/TextTrack.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698