Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2684973013: Remove unused string and fix punctuation in IDS_PAGE_INFO_INTERNAL_PAGE (Closed)

Created:
3 years, 10 months ago by meacer
Modified:
3 years, 10 months ago
Reviewers:
palmer, sdefresne
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, srahim+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused string and fix punctuation in IDS_PAGE_INFO_INTERNAL_PAGE BUG=688621 Review-Url: https://codereview.chromium.org/2684973013 Cr-Commit-Position: refs/heads/master@{#450041} Committed: https://chromium.googlesource.com/chromium/src/+/46f057203075c8c568d281d5445b072dd445fa87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/components_chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/components_google_chrome_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
meacer
palmer, sdefresne: PTAL?
3 years, 10 months ago (2017-02-11 00:44:39 UTC) #4
palmer
lgtm
3 years, 10 months ago (2017-02-11 00:54:34 UTC) #5
sdefresne
components/ lgtm
3 years, 10 months ago (2017-02-13 13:59:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684973013/1
3 years, 10 months ago (2017-02-13 18:27:58 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 19:31:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46f057203075c8c568d281d5445b...

Powered by Google App Engine
This is Rietveld 408576698