Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: chrome/browser/ui/website_settings/website_settings_ui.cc

Issue 2684973013: Remove unused string and fix punctuation in IDS_PAGE_INFO_INTERNAL_PAGE (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | components/components_chromium_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/website_settings/website_settings_ui.cc
diff --git a/chrome/browser/ui/website_settings/website_settings_ui.cc b/chrome/browser/ui/website_settings/website_settings_ui.cc
index eb5d6ae97c6318a4338debb9e39c5a9ef708486a..926d87dd1beb43a10a06ef892c6766f8ac4e3883 100644
--- a/chrome/browser/ui/website_settings/website_settings_ui.cc
+++ b/chrome/browser/ui/website_settings/website_settings_ui.cc
@@ -160,8 +160,9 @@ WebsiteSettingsUI::IdentityInfo::GetSecurityDescription() const {
switch (identity_status) {
case WebsiteSettings::SITE_IDENTITY_STATUS_INTERNAL_PAGE:
- return CreateSecurityDescription(IDS_WEBSITE_SETTINGS_INTERNAL_PAGE,
- IDS_WEBSITE_SETTINGS_INTERNAL_PAGE);
+ // Internal pages have their own UI implementations which should never
+ // call this function.
+ NOTREACHED();
case WebsiteSettings::SITE_IDENTITY_STATUS_CERT:
case WebsiteSettings::SITE_IDENTITY_STATUS_EV_CERT:
case WebsiteSettings::SITE_IDENTITY_STATUS_CERT_REVOCATION_UNKNOWN:
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | components/components_chromium_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698