Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2684933011: M57: Add UseCounter for ServiceWorkerNavigationPreload. (Closed)

Created:
3 years, 10 months ago by falken
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

M57: Add UseCounter for ServiceWorkerNavigationPreload. We have a UMA already (ServiceWorker.NavigationPreload.HeaderSize) which gives the total count, but it's hard to compute the % of page views without a UseCounter. BUG=649558 Review-Url: https://codereview.chromium.org/2659043002 Cr-Commit-Position: refs/heads/master@{#448529} (cherry picked from commit d688b918acfbbf4572db430fefeea3374286baf1) Review-Url: https://codereview.chromium.org/2684933011 . Cr-Commit-Position: refs/branch-heads/2987@{#429} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/c3c0fd9fbf6ae5659395b941b80dc142e5ff83b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -8 lines) Patch
M content/browser/service_worker/service_worker_response_info.h View 4 chunks +6 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_response_info.cc View 5 chunks +19 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/resource_response.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/resource_response_info.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/resource_response_info.cc View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/resources/worker.js View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/use-counter.html View 1 chunk +64 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 3 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.cpp View 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
falken
3 years, 10 months ago (2017-02-10 05:32:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3c0fd9fbf6ae5659395b941b80dc142e5ff83b9.

Powered by Google App Engine
This is Rietveld 408576698