Add UseCounter for ServiceWorkerNavigationPreload.

Add UseCounter for ServiceWorkerNavigationPreload.

We have a UMA already (ServiceWorker.NavigationPreload.HeaderSize) which gives
the total count, but it's hard to compute the % of page views without a
UseCounter.

BUG=649558
Review-Url: https://codereview.chromium.org/2659043002
Cr-Commit-Position: refs/heads/master@{#448529}
Committed: https://chromium.googlesource.com/chromium/src/+/d688b918acfbbf4572db430fefeea3374286baf1

[falken, 2017-01-27 11:03:55]

falken@chromium.org changed reviewers:
+ horo@chromium.org

[falken, 2017-01-27 11:03:55]

horo@ ptal

[falken, 2017-01-27 11:04:01]

The CQ bit was checked by falken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 11:04:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 14:46:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 14:46:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2017-01-29 09:19:17]

On 2017/01/27 11:03:55, falken wrote:
> horo@ ptal

The production code looks good.

But the unit test you added fails when --enable-browser-side-navigation flags is
set (browser_side_navigation_content_unittests).
The ResourceRequestInfo of the original navigation requests must be
BrowserSideNavigation type when the flags is set.

[4132:4132:0127/053426.277372:13201794498:FATAL:service_worker_fetch_dispatcher.cc(526)]
Check failed: requester_info->IsBrowserSideNavigation().
#0 0x00000346166e base::debug::StackTrace::StackTrace()
#1 0x000003473a4b logging::LogMessage::~LogMessage()
#2 0x0000029a96d6
content::ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload()
#3 0x0000029ea74d
content::ServiceWorkerURLRequestJob::RequestBodyFileSizesResolved()
#4 0x0000029e9b6d content::ServiceWorkerURLRequestJob::StartRequest()

[falken, 2017-01-30 04:02:34]

Thanks. I decided to just remove the unit test, there is enough test coverage
from the layout test and it's better to make the patch small for merging.

I verified manually it works with the flag in Chrome and running the LayoutTests
with --additional-driver-flag=--enable-browser-side-navigation

I'd still like to add a general unit test for nav preload in URL request job,
but it doesn't need to be in this patch.

[falken, 2017-01-30 04:02:45]

The CQ bit was checked by falken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 04:02:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 05:51:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 05:51:46]

Dry run: This issue passed the CQ dry run.

[horo, 2017-01-30 16:29:15]

lgtm

[falken, 2017-01-31 00:00:28]

falken@chromium.org changed reviewers:
+ jochen@chromium.org, tsepez@chromium.org

[falken, 2017-01-31 00:00:28]

jochen: Can you review everything except resource_messages.h?
tsepez: Can you review resource_messages.h?

[Tom Sepez, 2017-01-31 00:33:59]

lgtm

[falken, 2017-02-03 00:35:05]

falken@chromium.org changed reviewers:
+ alexmos@chromium.org, jwd@chromium.org, tkent@chromium.org
- jochen@chromium.org

[falken, 2017-02-03 00:35:06]

Adding owners.

alexmos: content/child and content/public 
jbroman: WebKit/Source
tkent: WebKit/public
jwd: histograms

[falken, 2017-02-03 00:35:31]

falken@chromium.org changed reviewers:
+ jbroman@chromium.org

[falken, 2017-02-03 00:35:32]

+jbroman for WebKit/Source

[tkent, 2017-02-03 00:55:19]

> tkent: WebKit/public

lgtm

https://codereview.chromium.org/2659043002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/2659043002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:508:
UseCounter::count(m_frame->document(),
nit: You can use UseCounter::count(m_frame, ...).

[alexmos, 2017-02-03 00:58:21]

content/child and content/public LGTM

[falken, 2017-02-03 01:07:07]

Thanks, done.

https://codereview.chromium.org/2659043002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/2659043002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:508:
UseCounter::count(m_frame->document(),
On 2017/02/03 00:55:19, tkent wrote:
> nit: You can use UseCounter::count(m_frame, ...).

Done.

[falken, 2017-02-04 00:35:48]

ping jbroman and jwd

[jbroman, 2017-02-04 18:27:28]

lgtm

[jwd, 2017-02-06 15:50:38]

lgtm

[falken, 2017-02-07 00:56:09]

The CQ bit was checked by falken@chromium.org

[falken, 2017-02-07 00:56:10]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org,
tsepez@chromium.org, tkent@chromium.org, alexmos@chromium.org,
jbroman@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2659043002/#ps160001
(title: "patch for landing")

[commit-bot: I haz the power, 2017-02-07 00:57:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 02:58:40]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1486428969601710,
"parent_rev": "83e43b393d1377dd186dfe0efbf9b45a8a8371c1", "commit_rev":
"d688b918acfbbf4572db430fefeea3374286baf1"}

[commit-bot: I haz the power, 2017-02-07 02:59:16]

Description was changed from

==========
Add UseCounter for ServiceWorkerNavigationPreload.

We have a UMA already (ServiceWorker.NavigationPreload.HeaderSize) which gives
the total count, but it's hard to compute the % of page views without a
UseCounter.

BUG=649558
==========

to

==========
Add UseCounter for ServiceWorkerNavigationPreload.

We have a UMA already (ServiceWorker.NavigationPreload.HeaderSize) which gives
the total count, but it's hard to compute the % of page views without a
UseCounter.

BUG=649558

Review-Url: https://codereview.chromium.org/2659043002
Cr-Commit-Position: refs/heads/master@{#448529}
Committed:
https://chromium.googlesource.com/chromium/src/+/d688b918acfbbf4572db430fefee...
==========

[commit-bot: I haz the power, 2017-02-07 02:59:18]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/d688b918acfbbf4572db430fefee...