Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2684843006: Revert of Reland "Android: Add owned resources to android studio" (Closed)

Created:
3 years, 10 months ago by Peter Wen
Modified:
3 years, 10 months ago
Reviewers:
estevenson, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland "Android: Add owned resources to android studio" (patchset #3 id:40001 of https://codereview.chromium.org/2687453002/ ) Reason for revert: Nonetype is not iterable. Original issue's description: > Reland "Android: Add owned resources to android studio" > > Original CL: https://codereview.chromium.org/2667023002/ > > Changes: > - Generalize srcjars and resource zips to be generated together. > - Update documentation > > BUG=682846 > > Review-Url: https://codereview.chromium.org/2687453002 > Cr-Commit-Position: refs/heads/master@{#449345} > Committed: https://chromium.googlesource.com/chromium/src/+/5c3f5db756cc0aa3c9b27893a567131557a0a83c TBR=estevenson@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=682846 Review-Url: https://codereview.chromium.org/2684843006 Cr-Commit-Position: refs/heads/master@{#449375} Committed: https://chromium.googlesource.com/chromium/src/+/2542e2ce6ab3528312438f99808cb329e4f11ee9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -42 lines) Patch
M build/android/gradle/android.jinja View 1 chunk +0 lines, -5 lines 0 comments Download
M build/android/gradle/generate_gradle.py View 9 chunks +10 lines, -29 lines 0 comments Download
M docs/android_studio.md View 4 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Peter Wen
Created Revert of Reland "Android: Add owned resources to android studio"
3 years, 10 months ago (2017-02-09 19:32:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684843006/1
3 years, 10 months ago (2017-02-09 19:33:31 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 19:34:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2542e2ce6ab3528312438f99808c...

Powered by Google App Engine
This is Rietveld 408576698