Reland "Android: Add owned resources to android studio"

Reland "Android: Add owned resources to android studio"

Original CL: https://codereview.chromium.org/2667023002/

Changes:
- Generalize srcjars and resource zips to be generated together.
- Update documentation

BUG=682846
Review-Url: https://codereview.chromium.org/2687453002
Cr-Commit-Position: refs/heads/master@{#449345}
Committed: https://chromium.googlesource.com/chromium/src/+/5c3f5db756cc0aa3c9b27893a567131557a0a83c

[Peter Wen, 2017-02-07 16:55:05]

wnwen@chromium.org changed reviewers:
+ estevenson@chromium.org

[Peter Wen, 2017-02-07 16:55:06]

Tested with clean out directory, clean AndroidStudio, and otherwise.

Also made target examples clearer according to feedback on
go/clank/engineering/development-tools/android-studio.

[estevenson, 2017-02-09 14:08:03]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2017-02-09 14:08:04]

Makes sense to me!

+agrieve@

[agrieve, 2017-02-09 15:29:32]

lgtm /w possible nit

https://codereview.chromium.org/2687453002/diff/20001/build/android/gradle/ge...
File build/android/gradle/generate_gradle.py (right):

https://codereview.chromium.org/2687453002/diff/20001/build/android/gradle/ge...
build/android/gradle/generate_gradle.py:65: if not path_or_list:
The following line says:

if not isinstance(path_or_list, basestring:
  return [...]

So I think it already returns an empty list for None or []. This would make it
return an empty list for an empty string input, which i think is wrong.

[Peter Wen, 2017-02-09 16:42:05]

Thanks for the review!

https://codereview.chromium.org/2687453002/diff/20001/build/android/gradle/ge...
File build/android/gradle/generate_gradle.py (right):

https://codereview.chromium.org/2687453002/diff/20001/build/android/gradle/ge...
build/android/gradle/generate_gradle.py:65: if not path_or_list:
On 2017/02/09 15:29:31, agrieve wrote:
> The following line says:
> 
> if not isinstance(path_or_list, basestring:
>   return [...]
> 
> So I think it already returns an empty list for None or []. This would make it
> return an empty list for an empty string input, which i think is wrong.

Opps, you're right. Fixed now.

[Peter Wen, 2017-02-09 16:42:11]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 16:42:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-02-09 17:14:08]

The CQ bit was unchecked by wnwen@chromium.org

[Peter Wen, 2017-02-09 17:14:11]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-02-09 17:14:12]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2687453002/#ps40001
(title: "Fix per review")

[commit-bot: I haz the power, 2017-02-09 17:14:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 17:48:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486660451902730,
"parent_rev": "4de117544debac896ba8205f8835ba9ed484a4d3", "commit_rev":
"5c3f5db756cc0aa3c9b27893a567131557a0a83c"}

[commit-bot: I haz the power, 2017-02-09 17:49:02]

Description was changed from

==========
Reland "Android: Add owned resources to android studio"

Original CL: https://codereview.chromium.org/2667023002/

Changes:
- Generalize srcjars and resource zips to be generated together.
- Update documentation

BUG=682846
==========

to

==========
Reland "Android: Add owned resources to android studio"

Original CL: https://codereview.chromium.org/2667023002/

Changes:
- Generalize srcjars and resource zips to be generated together.
- Update documentation

BUG=682846

Review-Url: https://codereview.chromium.org/2687453002
Cr-Commit-Position: refs/heads/master@{#449345}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c3f5db756cc0aa3c9b27893a567...
==========

[commit-bot: I haz the power, 2017-02-09 17:49:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5c3f5db756cc0aa3c9b27893a567...

[Peter Wen, 2017-02-09 19:32:20]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2684843006/ by wnwen@chromium.org.

The reason for reverting is: Nonetype is not iterable..