Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2684833002: Revert of Remove build_overrides/v8.gni. (Closed)

Created:
3 years, 10 months ago by mthiesse
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove build_overrides/v8.gni. (patchset #2 id:20001 of https://codereview.chromium.org/2660523002/ ) Reason for revert: build_overrides/v8.gni is still used by clank/java/BUILD.gn Original issue's description: > Remove build_overrides/v8.gni. > > This is no longer used by V8 and has been replaced by the default_args variable > in the //.gn file. > > BUG=684096 > > Review-Url: https://codereview.chromium.org/2660523002 > Cr-Commit-Position: refs/heads/master@{#448749} > Committed: https://chromium.googlesource.com/chromium/src/+/e97ef561379aadc367fcde3ebc5b37fa4001796f TBR=machenbach@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684096 Review-Url: https://codereview.chromium.org/2684833002 Cr-Commit-Position: refs/heads/master@{#448813} Committed: https://chromium.googlesource.com/chromium/src/+/3273e13c90a9aca77955c9a386bc66f57dded38f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A build_overrides/v8.gni View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mthiesse
Created Revert of Remove build_overrides/v8.gni.
3 years, 10 months ago (2017-02-08 00:13:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684833002/1
3 years, 10 months ago (2017-02-08 00:14:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3273e13c90a9aca77955c9a386bc66f57dded38f
3 years, 10 months ago (2017-02-08 00:16:19 UTC) #6
Michael Achenbach
3 years, 10 months ago (2017-02-08 07:36:48 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698