Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2660523002:
Remove build_overrides/v8.gni. (Closed)
|
Created:
3 years, 11 months ago by brettw Modified:
3 years, 10 months ago Reviewers:
Michael Achenbach CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove build_overrides/v8.gni.
This is no longer used by V8 and has been replaced by the default_args variable
in the //.gn file.
BUG=684096
Review-Url: https://codereview.chromium.org/2660523002
Cr-Commit-Position: refs/heads/master@{#449452}
Committed: https://chromium.googlesource.com/chromium/src/+/b54d63099501ccd240c5ab1d4e8f2ddbb0015b2d
Patch Set 1 #Patch Set 2 : Remove build_overrides/v8.gni. #
Messages
Total messages: 18 (9 generated)
brettw@chromium.org changed reviewers: + machenbach@chromium.org
I'll commit this after V8 rolls. I think this should be the last one.
lgtm - maybe wait 1-2 days after the roll as we require each V8 canary to be revertible to the previous canary version.
Sure, will land Monday.
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486498575141840,
"parent_rev": "46dad8ad40bd4d9e579974ee96568dd9b5cf6551", "commit_rev":
"e97ef561379aadc367fcde3ebc5b37fa4001796f"}
Message was sent while issue was closed.
Description was changed from ========== Remove build_overrides/v8.gni. This is no longer used by V8 and has been replaced by the default_args variable in the //.gn file. BUG=684096 ========== to ========== Remove build_overrides/v8.gni. This is no longer used by V8 and has been replaced by the default_args variable in the //.gn file. BUG=684096 Review-Url: https://codereview.chromium.org/2660523002 Cr-Commit-Position: refs/heads/master@{#448749} Committed: https://chromium.googlesource.com/chromium/src/+/e97ef561379aadc367fcde3ebc5b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e97ef561379aadc367fcde3ebc5b...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2684833002/ by mthiesse@chromium.org. The reason for reverting is: build_overrides/v8.gni is still used by clank/java/BUILD.gn.
Message was sent while issue was closed.
Description was changed from ========== Remove build_overrides/v8.gni. This is no longer used by V8 and has been replaced by the default_args variable in the //.gn file. BUG=684096 Review-Url: https://codereview.chromium.org/2660523002 Cr-Commit-Position: refs/heads/master@{#448749} Committed: https://chromium.googlesource.com/chromium/src/+/e97ef561379aadc367fcde3ebc5b... ========== to ========== Remove build_overrides/v8.gni. This is no longer used by V8 and has been replaced by the default_args variable in the //.gn file. BUG=684096 Review-Url: https://codereview.chromium.org/2660523002 Cr-Commit-Position: refs/heads/master@{#448749} Committed: https://chromium.googlesource.com/chromium/src/+/e97ef561379aadc367fcde3ebc5b... ==========
Description was changed from ========== Remove build_overrides/v8.gni. This is no longer used by V8 and has been replaced by the default_args variable in the //.gn file. BUG=684096 Review-Url: https://codereview.chromium.org/2660523002 Cr-Commit-Position: refs/heads/master@{#448749} Committed: https://chromium.googlesource.com/chromium/src/+/e97ef561379aadc367fcde3ebc5b... ========== to ========== Remove build_overrides/v8.gni. This is no longer used by V8 and has been replaced by the default_args variable in the //.gn file. BUG=684096 ==========
Re-landing with no changes now that the reference to this file has been removed from the internal Clank repo.
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486676939931800,
"parent_rev": "24835036681c326052b092b9697333ad9f4c2a9b", "commit_rev":
"b54d63099501ccd240c5ab1d4e8f2ddbb0015b2d"}
Message was sent while issue was closed.
Description was changed from ========== Remove build_overrides/v8.gni. This is no longer used by V8 and has been replaced by the default_args variable in the //.gn file. BUG=684096 ========== to ========== Remove build_overrides/v8.gni. This is no longer used by V8 and has been replaced by the default_args variable in the //.gn file. BUG=684096 Review-Url: https://codereview.chromium.org/2660523002 Cr-Commit-Position: refs/heads/master@{#449452} Committed: https://chromium.googlesource.com/chromium/src/+/b54d63099501ccd240c5ab1d4e8f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b54d63099501ccd240c5ab1d4e8f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
