Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2684733002: IntersectionObserver: discard notifications upon disconnect(). (Closed)

Created:
3 years, 10 months ago by szager1
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IntersectionObserver: discard notifications upon disconnect(). BUG=686458 R=ojan@chromium.org,zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2684733002 Cr-Commit-Position: refs/heads/master@{#448802} Committed: https://chromium.googlesource.com/chromium/src/+/0591e6b5e4e2ded7d48edc18e20a6ed2466fd19a

Patch Set 1 #

Patch Set 2 : Add layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/intersection-observer/disconnect.html View 1 1 chunk +56 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
szager1
3 years, 10 months ago (2017-02-07 20:22:54 UTC) #1
Zhiqiang Zhang (Slow)
lgtm
3 years, 10 months ago (2017-02-07 20:37:36 UTC) #2
Zhiqiang Zhang (Slow)
Put comments on the bug about reverting my CL and landing yours.
3 years, 10 months ago (2017-02-07 20:41:40 UTC) #3
Zhiqiang Zhang (Slow)
On 2017/02/07 20:41:40, Zhiqiang Zhang wrote: > Put comments on the bug about reverting my ...
3 years, 10 months ago (2017-02-07 20:44:21 UTC) #4
szager1
Still need ojan for OWNERS
3 years, 10 months ago (2017-02-07 21:20:55 UTC) #7
ojan
lgtm to land, but I think we should followup with a spec change as well. ...
3 years, 10 months ago (2017-02-07 21:38:27 UTC) #8
szager1
On 2017/02/07 21:38:27, ojan wrote: > lgtm to land, but I think we should followup ...
3 years, 10 months ago (2017-02-07 21:44:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684733002/20001
3 years, 10 months ago (2017-02-07 21:46:25 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:55:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0591e6b5e4e2ded7d48edc18e20a...

Powered by Google App Engine
This is Rietveld 408576698