third_party/WebKit/Source/core/dom/IntersectionObserver.cpp - Issue 2684733002: IntersectionObserver: discard notifications upon disconnect().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

Issue 2684733002: IntersectionObserver: discard notifications upon disconnect(). (Closed)

Patch Set: Add layout test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

index 779e0a33ee2e35c852bc3c5e199561fbdf7750b4..85dc34831757df6dfc68c3aa100ba96d0073f147 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

@@ -306,6 +306,7 @@ void IntersectionObserver::disconnect(ExceptionState& exceptionState) {

for (auto& observation : m_observations)

observation->disconnect();

m_observations.clear();

+ m_entries.clear();

}

HeapVector<Member<IntersectionObserverEntry>> IntersectionObserver::takeRecords(