Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2684663002: Part 2: Browser tests for using the new SafeBrowsing protocol (v4) (Closed)

Created:
3 years, 10 months ago by vakh (use Gerrit instead)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More browser tests for PVer4. Converts the existing PVer3 tests to PVer4 by *only* changing the way prefixes and full hashes are stuffed into the DB and full hash cache respectively. The rest of the lines in the tests are identical. Part 1: http://crrev.com/2675063002 Part 2: http://crrev.com/2684663002 (this CL) Part 3: http://crrev.com/2683813002 BUG=682495 Review-Url: https://codereview.chromium.org/2684663002 Cr-Commit-Position: refs/heads/master@{#450177} Committed: https://chromium.googlesource.com/chromium/src/+/0864e253f3e391b6c7d66c4ea70fbab27c8599e4

Patch Set 1 #

Patch Set 2 : More tests, including SubResource ones #

Patch Set 3 : rebase + fix failures after rebase #

Total comments: 3

Patch Set 4 : rebase #

Patch Set 5 : nparker@'s review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -35 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 2 3 4 9 chunks +367 lines, -35 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 34 (25 generated)
vakh (use Gerrit instead)
3 years, 10 months ago (2017-02-07 17:51:58 UTC) #4
vakh (use Gerrit instead)
More tests, including SubResource ones
3 years, 10 months ago (2017-02-07 19:02:33 UTC) #7
vakh (use Gerrit instead)
rebase + fix failures after rebase
3 years, 10 months ago (2017-02-09 19:41:51 UTC) #12
Nathan Parker
lgtm I didn't look super closely at the test contents. https://codereview.chromium.org/2684663002/diff/40001/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc File chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc (right): https://codereview.chromium.org/2684663002/diff/40001/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc#newcode666 ...
3 years, 10 months ago (2017-02-10 01:05:21 UTC) #17
vakh (use Gerrit instead)
rebase
3 years, 10 months ago (2017-02-13 20:37:59 UTC) #19
vakh (use Gerrit instead)
nparker@'s review
3 years, 10 months ago (2017-02-13 21:42:35 UTC) #22
commit-bot: I haz the power
This CL has an open dependency (Issue 2675063002 Patch 280001). Please resolve the dependency and ...
3 years, 10 months ago (2017-02-13 21:43:31 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684663002/80001
3 years, 10 months ago (2017-02-13 23:11:34 UTC) #31
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 00:53:31 UTC) #34
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0864e253f3e391b6c7d66c4ea70f...

Powered by Google App Engine
This is Rietveld 408576698