Part 3: Browser tests for calling client methods Check*Url with PVer4

Tests for calling client methods: Check*Url

Part 1: http://crrev.com/2675063002
Part 2: http://crrev.com/2684663002
Part 3: http://crrev.com/2683813002 (this CL)

BUG=682495
Review-Url: https://codereview.chromium.org/2683813002
Cr-Commit-Position: refs/heads/master@{#450180}
Committed: https://chromium.googlesource.com/chromium/src/+/dfca1068b4dee7a7959426a1f95960d49b023d4f

[vakh (use Gerrit instead), 2017-02-07 21:30:16]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 21:31:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 22:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 22:24:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vakh (use Gerrit instead), 2017-02-09 20:04:38]

rebase + fix failures after rebase

[vakh (use Gerrit instead), 2017-02-09 20:04:39]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 20:06:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 20:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 20:53:54]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vakh (use Gerrit instead), 2017-02-09 23:25:03]

Test CheckResourceUrl only when GOOGLE_CHROME_BUILD is defined

[vakh (use Gerrit instead), 2017-02-09 23:25:05]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 23:25:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 00:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:10:04]

Dry run: This issue passed the CQ dry run.

[vakh (use Gerrit instead), 2017-02-13 21:58:28]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 21:59:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2017-02-13 21:59:46]

rebase

[vakh (use Gerrit instead), 2017-02-13 21:59:48]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 22:00:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2017-02-13 22:02:47]

Description was changed from

==========
Tests for calling client methods: Check*Url

Follow-up from CLs:
- http://crrev.com/2675063002
- http://crrev.com/2684663002

BUG=682495
==========

to

==========
Tests for calling client methods: Check*Url

Part 1: http://crrev.com/2675063002
Part 2: http://crrev.com/2684663002
Part 3: http://crrev.com/2683813002 (this CL)

BUG=682495
==========

[vakh (use Gerrit instead), 2017-02-13 22:21:01]

Added comments for clarity

[vakh (use Gerrit instead), 2017-02-13 22:21:02]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 22:21:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2017-02-13 23:27:06]

vakh@chromium.org changed reviewers:
+ nparker@chromium.org

[commit-bot: I haz the power, 2017-02-13 23:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 23:48:46]

Dry run: This issue passed the CQ dry run.

[Nathan Parker, 2017-02-14 00:03:49]

https://codereview.chromium.org/2683813002/diff/80001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc (right):

https://codereview.chromium.org/2683813002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc:2029:
TestV4StoreFactory* store_factory_;
This isn't really owned... more of "leaked," ya? Not a big deal.

https://codereview.chromium.org/2683813002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc:2408: GURL
badbin_url = embedded_test_server()->GetURL(kMalwareFile);
What in these tests points it at Pver4 impl?

[vakh (use Gerrit instead), 2017-02-14 00:07:19]

https://codereview.chromium.org/2683813002/diff/80001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc (right):

https://codereview.chromium.org/2683813002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc:2029:
TestV4StoreFactory* store_factory_;
On 2017/02/14 00:03:49, Nathan Parker wrote:
> This isn't really owned... more of "leaked," ya? Not a big deal.

Sort of, yes. From the perspective of this code, it is owned by V4Database
because it sends the unique pointer over. That V4Database decides to leak it
intentionally is an implementation detail of V4Database for this code.

https://codereview.chromium.org/2683813002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc:2408: GURL
badbin_url = embedded_test_server()->GetURL(kMalwareFile);
On 2017/02/14 00:03:49, Nathan Parker wrote:
> What in these tests points it at Pver4 impl?


  void SetUp() override {
    sb_factory_ = base::MakeUnique<TestSafeBrowsingServiceFactory>(
        V4FeatureList::V4UsageStatus::V4_ONLY);
  ...
  ...
  }

[Nathan Parker, 2017-02-14 00:17:31]

lgtm

[vakh (use Gerrit instead), 2017-02-14 00:54:03]

The CQ bit was checked by vakh@chromium.org

[commit-bot: I haz the power, 2017-02-14 00:54:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 01:05:33]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487033643010890,
"parent_rev": "b54401a5a1107d8440ddad54effecca920553fa6", "commit_rev":
"dfca1068b4dee7a7959426a1f95960d49b023d4f"}

[commit-bot: I haz the power, 2017-02-14 01:07:18]

Description was changed from

==========
Tests for calling client methods: Check*Url

Part 1: http://crrev.com/2675063002
Part 2: http://crrev.com/2684663002
Part 3: http://crrev.com/2683813002 (this CL)

BUG=682495
==========

to

==========
Tests for calling client methods: Check*Url

Part 1: http://crrev.com/2675063002
Part 2: http://crrev.com/2684663002
Part 3: http://crrev.com/2683813002 (this CL)

BUG=682495

Review-Url: https://codereview.chromium.org/2683813002
Cr-Commit-Position: refs/heads/master@{#450180}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfca1068b4dee7a7959426a1f959...
==========

[commit-bot: I haz the power, 2017-02-14 01:07:20]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/dfca1068b4dee7a7959426a1f959...