Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2684593006: Remove ScriptValueSerializer::serializeNullValue. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
Reviewers:
haraken, MrJOHN
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jbroman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScriptValueSerializer::serializeNullValue. Replace it with a hard-coded encoding of "null" (at version 9, though it doesn't much matter since we are be backward-compatible). BUG=690132 Review-Url: https://codereview.chromium.org/2684593006 Cr-Commit-Position: refs/heads/master@{#449173} Committed: https://chromium.googlesource.com/chromium/src/+/0e09de60e479fe2ee105fb731b403c729fce3ac1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jbroman
3 years, 10 months ago (2017-02-08 22:15:54 UTC) #4
haraken
LGTM
3 years, 10 months ago (2017-02-09 01:02:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684593006/1
3 years, 10 months ago (2017-02-09 01:06:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0e09de60e479fe2ee105fb731b403c729fce3ac1
3 years, 10 months ago (2017-02-09 01:13:33 UTC) #12
MrJOHN
3 years, 10 months ago (2017-02-22 23:35:01 UTC) #14
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698