third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp - Issue 2684593006: Remove ScriptValueSerializer::serializeNullValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

Issue 2684593006: Remove ScriptValueSerializer::serializeNullValue. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

index 06ead69bf05e9c36ccf0f7b397d2614d69db8fd3..a9edce88e1073e7423181f392e337e42e88634b7 100644

--- a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

@@ -132,7 +132,9 @@ SerializedScriptValue::~SerializedScriptValue() {

}

PassRefPtr<SerializedScriptValue> SerializedScriptValue::nullValue() {

- return create(ScriptValueSerializer::serializeNullValue());

+ // UChar rather than uint8_t here to get host endian behavior.

+ static const UChar kNullData[] = {0xff09, 0x3000};

+ return create(reinterpret_cast<const char*>(kNullData), sizeof(kNullData));

}

String SerializedScriptValue::toWireString() const {