Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2684423004: WPT Auto-import: fix for owner list in import CLs. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina, tkent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WPT Auto-import: fix for owner list in import CLs. This is a follow-up fix for http://crrev.com/2684663003. The mistake was: In one part of the code I was assuming that get_directory_owners() would return a map from owner to list of directories, but in reality it returned a dict from owner to single directory (string). We want to have lists of directories, since a single import CL will often have modifications to many directories for one owner. This resulted in silly-looking CL descriptions like http://crrev.com/2687343002. BUG=687270 Review-Url: https://codereview.chromium.org/2684423004 Cr-Commit-Position: refs/heads/master@{#449666} Committed: https://chromium.googlesource.com/chromium/src/+/0ccb652d00c6fbd072608a7bdbb9f1fbe17fd87d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
qyearsley
3 years, 10 months ago (2017-02-10 17:21:08 UTC) #3
jeffcarp
lgtm
3 years, 10 months ago (2017-02-10 17:26:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684423004/1
3 years, 10 months ago (2017-02-10 17:33:41 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 18:36:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ccb652d00c6fbd072608a7bdbb9...

Powered by Google App Engine
This is Rietveld 408576698