third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py - Issue 2684423004: WPT Auto-import: fix for owner list in import CLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py

Issue 2684423004: WPT Auto-import: fix for owner list in import CLs. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py

index 189570e8a2d93488f403d970f8a5c5c3b9e2cfdd..3fbfc496cb929d59cb521e41e8b42cbde2affd4b 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py

@@ -39,17 +39,22 @@ class DirectoryOwnersExtractorTest(unittest.TestCase):

self.extractor.owner_map = {

'external/wpt/foo': ['a@chromium.org'],

'external/wpt/bar': ['b@chromium.org'],

+ 'external/wpt/baz': ['a@chromium.org'],

}

self.filesystem.files = {

'/mock-checkout/third_party/WebKit/LayoutTests/external/wpt/foo/x/y.html': '',

'/mock-checkout/third_party/WebKit/LayoutTests/external/wpt/bar/x/y.html': '',

+ '/mock-checkout/third_party/WebKit/LayoutTests/external/wpt/baz/x/y.html': '',

'/mock-checkout/third_party/WebKit/LayoutTests/external/wpt/quux/x/y.html': '',

}

changed_files = [

'third_party/WebKit/LayoutTests/external/wpt/foo/x/y.html',

+ 'third_party/WebKit/LayoutTests/external/wpt/baz/x/y.html',

'third_party/WebKit/LayoutTests/external/wpt/quux/x/y.html',

]

- self.assertEqual(self.extractor.list_owners(changed_files), {'a@chromium.org': 'external/wpt/foo'})

+ self.assertEqual(

+ self.extractor.list_owners(changed_files),

+ {'a@chromium.org': ['external/wpt/foo', 'external/wpt/baz']})

def test_extract_owner_positive_cases(self):

self.assertEqual(self.extractor.extract_owners('## Owners: foo@chromium.org'), ['foo@chromium.org'])