Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2684393003: [Merge] Use regular weight for password autofill popup on password field. (Closed)

Created:
3 years, 10 months ago by dvadym
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge] Use regular weight for password autofill popup on password field. A text in password suggestion popup should be bold iff this text is to be autofilled. So on a username field Username in the suggestion popup should be bold, but on a password field Username should be in regular text. BUG=686186 Review-Url: https://codereview.chromium.org/2681703002 Cr-Commit-Position: refs/heads/master@{#448945} (cherry picked from commit fb3db819dfcac399579102ecb93917c48d6769ce) Review-Url: https://codereview.chromium.org/2684393003 . Cr-Commit-Position: refs/branch-heads/2987@{#435} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/bb7bedd52c831328f3569501450ed8d8bc724ca9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -43 lines) Patch
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_layout_model.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/popup_item_ids.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_autofill_manager.cc View 4 chunks +14 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/password_autofill_manager_unittest.cc View 1 chunk +42 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dvadym
3 years, 10 months ago (2017-02-10 13:59:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bb7bedd52c831328f3569501450ed8d8bc724ca9.

Powered by Google App Engine
This is Rietveld 408576698