Use regular weight for password autofill popup on password field.

Use regular weight for password autofill popup on password field.

A text in password suggestion popup should be bold iff this text is to be autofilled. So on a username field Username in the suggestion popup should be bold, but on a password field Username should be in regular text.


BUG=686186
Review-Url: https://codereview.chromium.org/2681703002
Cr-Commit-Position: refs/heads/master@{#448945}
Committed: https://chromium.googlesource.com/chromium/src/+/fb3db819dfcac399579102ecb93917c48d6769ce

[dvadym, 2017-02-07 11:06:48]

Description was changed from

==========
format


BUG=686186
==========

to

==========
Use regular weight for password autofill popup on password field.

A text in password suggestion popup should be bold iff this text is to be
autofilled. So on a username field Username in the suggestion popup should be
bold, but on a password field Username should be in regular text.


BUG=686186
==========

[dvadym, 2017-02-07 12:01:58]

dvadym@chromium.org changed reviewers:
+ vasilii@chromium.org

[dvadym, 2017-02-07 12:02:39]

Hi Vasilii,

 could you please review components/password_manager/* ?

Regards,
Vadym

[vasilii, 2017-02-07 12:44:35]

Hi, the screenshots before and after would help a lot.

[vasilii, 2017-02-07 13:00:33]

lgtm

components/password_manager/*

[dvadym, 2017-02-07 13:07:01]

Thanks for review!
Currently it looks exactly how it's on the image in
https://bugs.chromium.org/p/chromium/issues/detail?id=686186#c2

[dvadym, 2017-02-07 13:09:19]

dvadym@chromium.org changed reviewers:
+ mathp@chromium.org

[dvadym, 2017-02-07 13:09:19]

Hi Mathieu,

 Could you please review changes in
   chrome/browser/ui/autofill/*
   components/autofill/* ?

Regards,
Vadym

[Mathieu, 2017-02-08 00:54:54]

lgtm

[dvadym, 2017-02-08 09:39:49]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2017-02-08 09:40:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 10:22:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486546789480450,
"parent_rev": "235cb99dc91534cc729e07a7b1ca5878ee57fcf5", "commit_rev":
"fb3db819dfcac399579102ecb93917c48d6769ce"}

[commit-bot: I haz the power, 2017-02-08 10:22:44]

Description was changed from

==========
Use regular weight for password autofill popup on password field.

A text in password suggestion popup should be bold iff this text is to be
autofilled. So on a username field Username in the suggestion popup should be
bold, but on a password field Username should be in regular text.


BUG=686186
==========

to

==========
Use regular weight for password autofill popup on password field.

A text in password suggestion popup should be bold iff this text is to be
autofilled. So on a username field Username in the suggestion popup should be
bold, but on a password field Username should be in regular text.


BUG=686186

Review-Url: https://codereview.chromium.org/2681703002
Cr-Commit-Position: refs/heads/master@{#448945}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb3db819dfcac399579102ecb939...
==========

[commit-bot: I haz the power, 2017-02-08 10:22:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fb3db819dfcac399579102ecb939...