[ObjC ARC] Converts ios/chrome/browser:unit_tests to ARC.

[ObjC ARC] Converts ios/chrome/browser:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2684263003
Cr-Commit-Position: refs/heads/master@{#449983}
Committed: https://chromium.googlesource.com/chromium/src/+/30ab8326aac843793024d240225a2ae273477876

[lody, 2017-02-10 15:54:41]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 15:55:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 17:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:01:18]

Dry run: This issue passed the CQ dry run.

[lody, 2017-02-13 10:53:19]

lod@chromium.org changed reviewers:
+ sdefresne@chromium.org, stkhapugin@chromium.org

[lody, 2017-02-13 10:53:19]

Much review, such wow

[sdefresne, 2017-02-13 14:21:23]

lgtm

https://codereview.chromium.org/2684263003/diff/1/ios/chrome/browser/installa...
File ios/chrome/browser/installation_notifier_unittest.mm (right):

https://codereview.chromium.org/2684263003/diff/1/ios/chrome/browser/installa...
ios/chrome/browser/installation_notifier_unittest.mm:25: @implementation
MockDispatcher {
This is not a mock, this is a fake :-(

https://codereview.chromium.org/2684263003/diff/1/ios/chrome/browser/installa...
ios/chrome/browser/installation_notifier_unittest.mm:154: installationNotifier_;
          // Weak pointer to singleton.
You can probably remove those comments now (since the code uses __weak).

[lody, 2017-02-13 15:40:10]

https://codereview.chromium.org/2684263003/diff/1/ios/chrome/browser/installa...
File ios/chrome/browser/installation_notifier_unittest.mm (right):

https://codereview.chromium.org/2684263003/diff/1/ios/chrome/browser/installa...
ios/chrome/browser/installation_notifier_unittest.mm:25: @implementation
MockDispatcher {
On 2017/02/13 14:21:23, sdefresne wrote:
> This is not a mock, this is a fake :-(

Done.

https://codereview.chromium.org/2684263003/diff/1/ios/chrome/browser/installa...
ios/chrome/browser/installation_notifier_unittest.mm:154: installationNotifier_;
          // Weak pointer to singleton.
On 2017/02/13 14:21:23, sdefresne wrote:
> You can probably remove those comments now (since the code uses __weak).

Done.

[lody, 2017-02-13 15:40:20]

The CQ bit was checked by lod@chromium.org

[lody, 2017-02-13 15:40:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2684263003/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-02-13 15:40:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 17:07:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487000420288300,
"parent_rev": "d5e21876e6309f01c38a8592c2885b1214ae610c", "commit_rev":
"30ab8326aac843793024d240225a2ae273477876"}

[commit-bot: I haz the power, 2017-02-13 17:08:32]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2684263003
Cr-Commit-Position: refs/heads/master@{#449983}
Committed:
https://chromium.googlesource.com/chromium/src/+/30ab8326aac843793024d240225a...
==========

[commit-bot: I haz the power, 2017-02-13 17:08:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/30ab8326aac843793024d240225a...